chore: Remove unused import #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also find a warning ,but I think that this may be a false warning. [warn] /home/laglang/coding/incubator-pekko-http/parsing/src/main/scala-2/org/apache/pekko/http/ccompat/pre213macro.scala:17:36: Unused import
[warn] import scala.language.experimental.macros
[warn] ^
[warn] /home/laglang/coding/incubator-pekko-http/parsing/src/main/scala-2/org/apache/pekko/http/ccompat/since213macro.scala:17:36: Unused import
[warn] import scala.language.experimental.macros
[warn] /home/laglang/coding/incubator-pekko-http/http/src/main/scala/org/apache/pekko/http/javadsl/server/RoutingJavaMapping.scala:37:27: Unused import
[warn] import scala.language.implicitConversions
[warn] ^
[warn] /home/laglang/coding/incubator-pekko-http/http/src/main/scala/org/apache/pekko/http/scaladsl/server/ExceptionHandler.scala:21:23: Unused import
[warn] import scala.language.implicitConversions
|
|
this breaks the scala 2.12 build - please close this |
Sorry,I didn't test it carefully on 2.12 before, and I still think some imports are not related to the scala version. I will review this PR again |
laglangyue
changed the title
mdedetrich
approved these changes
Dec 23, 2023
He-Pin
changed the title
He-Pin
pushed a commit
to He-Pin/incubator-pekko-http
that referenced
this pull request
Dec 24, 2023
* [Chore] remove unused import * [Chore] remove unused import * revert `pekko.http.ccompat._` * revert seq imports --------- Co-authored-by: Jiafu Tang <jiafu.tang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
such as title,remvoe some not import package
motivations:
I find there are some waning about
unusedtest:
Removed some
unused import, so I just compiled locally,it will test by CI