Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix todo link in CORS doc #386

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix todo link in CORS doc #386

merged 1 commit into from
Dec 28, 2023

Conversation

pjfanning
Copy link
Contributor

mdedetrich
mdedetrich approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also backport to 1.0.x

@pjfanning pjfanning merged commit cd6039f into apache:main Dec 28, 2023
14 checks passed
@pjfanning pjfanning deleted the fix-cors-todo branch December 28, 2023 09:04
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Dec 28, 2023
@pjfanning
fix todo link in CORS doc (apache#386)
1dfc8e8
@pjfanning pjfanning mentioned this pull request Dec 28, 2023
Merged
pjfanning added a commit that referenced this pull request Dec 28, 2023
@pjfanning
fix todo link in CORS doc (#386) (#388)
d49a8d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich