Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][doc] PIP-264: Add replication metrics reference #926

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

dragosvictor
Copy link
Contributor

@dragosvictor dragosvictor commented Jun 25, 2024

✅ Contribution Checklist

@dragosvictor dragosvictor force-pushed the dmisca-pip-264-replication-metrics branch from 9ad2f04 to bd038c6 Compare June 25, 2024 04:45
@dragosvictor dragosvictor marked this pull request as ready for review June 25, 2024 04:45
* `pulsar.replication.remote.cluster.name` - The name of the remote cluster.

#### pulsar.broker.replication.message.backlog.count
The total number of messages in the backlog for this replicator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify a little more here? something like

The total number of messages in the backlog for this replicator has not been consumed.

* `pulsar.replication.remote.cluster.name` - The name of the remote cluster.

#### pulsar.broker.replication.message.expired.count
The total number of messages that expired for this replicator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify a little more here? something like

The total number of messages that expired for this replicator before consuming.

The total number of messages received from the remote cluster through this replicator.
* Type: Counter
* Unit: `{message}`
* Attributes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like these attributes are copied multiple times. can we link a ref, instead?

@lhotari lhotari merged commit c6b0da3 into apache:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants