[fix][ci] Don't allow merging PR without successful result #22563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Apr 23, 2024
tisonkun
approved these changes
Apr 23, 2024
hezhangjian
approved these changes
Apr 23, 2024
nicoloboschi
approved these changes
Apr 23, 2024
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 24, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it's possible to merge a PR when it hasn't been approved at all and no tests have run. This was previously possible when a draft PR had been approved and then made ready to review. Another case was that where the PR had skipped running the build because of not being approved or having the ready-to-test label and then being approved before the tests where run. The reason for this is that the required job "Pulsar CI checks completed" got skipped in this case.
Modifications
Pulsar CI checks completedbuild step in the workflow.Documentation
docdoc-requireddoc-not-neededdoc-complete