Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add managed ledger cache metrics #22898

Merged

Conversation

dragosvictor
Copy link
Contributor

PIP-264

Motivation

Adds Managed Ledger cache metrics to the OpenTelemetry pipeline.

Modifications

  • Adds the metrics described in [feat][doc] PIP-264: Add OpenTelemetry ML cache metrics reference pulsar-site#913 to the collector runs.
  • Pass OpenTelemetry instance to the ManagedClientFactoryImpl constructor, to be used by all ML OTel metrics.
  • Factor out functionality currently located in ManagedLedgerCacheMetrics to PooledByteBufAllocatorStats.java, for reuse in the the OTel stats collection.
  • Add field Rate.totalValueAdder keeping track of cumulative values added to the Rate, further simplifying the design.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added metric test in OpenTelemetryManagedLedgerCacheStatsTest

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: dragosvictor#33

@dragosvictor dragosvictor marked this pull request as ready for review June 12, 2024 18:03
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jun 12, 2024
@merlimat merlimat added this to the 3.4.0 milestone Jun 21, 2024
@lhotari lhotari merged commit fe726db into apache:master Jun 26, 2024
53 of 57 checks passed
@dragosvictor dragosvictor deleted the dmisca-pip-264-managed-ledger-cache-metrics branch June 26, 2024 17:03
shibd added a commit to shibd/pulsar that referenced this pull request Jul 3, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants