-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Copy eventTime to retry letter topic and DLQ messages #24059
Conversation
@SantanuKar43 Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @SantanuKar43. One comment about a small detail.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @SantanuKar43
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24059 +/- ##
============================================
+ Coverage 73.57% 74.17% +0.59%
+ Complexity 32624 32399 -225
============================================
Files 1877 1861 -16
Lines 139502 144213 +4711
Branches 15299 16433 +1134
============================================
+ Hits 102638 106966 +4328
+ Misses 28908 28802 -106
- Partials 7956 8445 +489
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes #24053
Motivation
See #24053
Modifications
copy eventTime to messages sent to retry letter topic and DLQ topic
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: SantanuKar43#1