Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] Copy eventTime to retry letter topic and DLQ messages #24059

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

SantanuKar43
Copy link
Contributor

@SantanuKar43 SantanuKar43 commented Mar 5, 2025

Fixes #24053

Motivation

See #24053

Modifications

copy eventTime to messages sent to retry letter topic and DLQ topic

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added integration tests : RetryTopicTest#testRetryTopicProperties, DeadLetterTopicTest#testDeadLetterTopicMessagesWithEventTime

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: SantanuKar43#1

Copy link

github-actions bot commented Mar 5, 2025

@SantanuKar43 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 5, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @SantanuKar43. One comment about a small detail.

@SantanuKar43 SantanuKar43 requested a review from lhotari March 5, 2025 15:11
@lhotari lhotari changed the title [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [fix][client] Copy eventTime to retry letter topic and DLQ messages Mar 5, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @SantanuKar43

@lhotari lhotari added this to the 4.1.0 milestone Mar 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.17%. Comparing base (bbc6224) to head (f28094f).
Report is 949 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24059      +/-   ##
============================================
+ Coverage     73.57%   74.17%   +0.59%     
+ Complexity    32624    32399     -225     
============================================
  Files          1877     1861      -16     
  Lines        139502   144213    +4711     
  Branches      15299    16433    +1134     
============================================
+ Hits         102638   106966    +4328     
+ Misses        28908    28802     -106     
- Partials       7956     8445     +489     
Flag Coverage Δ
inttests 26.71% <80.00%> (+2.13%) ⬆️
systests 23.15% <0.00%> (-1.17%) ⬇️
unittests 73.68% <100.00%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 79.04% <100.00%> (+1.47%) ⬆️
...he/pulsar/client/impl/TypedMessageBuilderImpl.java 84.61% <ø> (+0.76%) ⬆️

... and 1060 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 8303b96 into apache:master Mar 5, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc-not-needed Your PR changes do not impact docs release/3.0.11 release/3.3.6 release/4.0.4 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] message eventtime is reset to 0 on reconsumeLater
4 participants