-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insitu query logging & request timeouts #207
Open
RKuttruff
wants to merge
39
commits into
apache:master
Choose a base branch
from
RKuttruff:insitu-query-logging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
0aafb34
Added time & status to insitu request logging
ba003d0
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 5accf13
Attempt at logging IS query URL before request is made
RKuttruff 1071995
Handle logging for next page
b3de561
Changelog
a3a0ef4
Merge branch 'apache:master' into insitu-query-logging
RKuttruff b475f17
Merge remote-tracking branch 'origin/master' into insitu-query-logging
5e35ca6
Added explicit timeouts plus NPEs on timout
8841861
Updated CHANGELOG.md
c595569
Schema timeout
ececbd0
Made timeout variables
8c95f33
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 2fb6962
Merge remote-tracking branch 'origin/master' into insitu-query-logging
89429fc
Merge remote-tracking branch 'origin/master' into insitu-query-logging
f6c43b9
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 5c4b421
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 469d789
Moved changelog entry
3b1d916
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 8b6225b
Merge remote-tracking branch 'origin/master' into insitu-query-logging
170bf45
Merge remote-tracking branch 'origin/master' into insitu-query-logging
ec62e69
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 90e086d
Logging: non-root + log count of returned points
44b1b18
Merge branch 'apache:master' into insitu-query-logging
RKuttruff ae7db38
Merge branch 'apache:master' into insitu-query-logging
RKuttruff d7aa528
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 0251e5b
Merge remote-tracking branch 'origin/master' into insitu-query-logging
ef272e8
Merge remote-tracking branch 'origin/master' into insitu-query-logging
e7b8251
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 9d998f5
Merge remote-tracking branch 'origin/master' into insitu-query-logging
6e38477
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 6be503b
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 7a74bae
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 373aef9
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 8e8f5d6
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 68d8227
Merge remote-tracking branch 'origin/master' into insitu-query-logging
34a23ef
Merge remote-tracking branch 'origin/master' into insitu-query-logging
8985b7d
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 69907b4
Merge branch 'apache:master' into insitu-query-logging
RKuttruff 42b71ec
Merge branch 'apache:master' into insitu-query-logging
RKuttruff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the justification of setting these values separately? Also, why 331 and not 300 (the gateway timeout we have configured)? Also curious why you chose 15.05
Also, we should probably avoid magic numbers and assign these values to variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by the first question.
I chose the numbers (primarily 15.05) since the documentation for setting timeouts recommends setting it to a little bit higher than a multiple of 3, so I picked one admittedly arbitrarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant why set
timeout=(15.05, 331)
rather thantimeout=331
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First one is connect timeout, second is read timeout.
I suppose it would be beneficial to fail quickly if we can't even connect rather than wait a whole 5 minutes