[Improve][feature] Add JobInstance Delete #161
Conversation
| @@ -71,11 +71,12 @@ | |||
| <guava.version>19.0</guava.version> | |||
| <checker.qual.version>3.10.0</checker.qual.version> | |||
| <awaitility.version>4.2.0</awaitility.version> | |||
| <seatunnel-framework.version>2.3.3</seatunnel-framework.version> | |||
| <seatunnel-framework.version>2.3.4</seatunnel-framework.version> | |||
There was a problem hiding this comment.
as seatunnel 2.3.5 is released, can you pls update seatunnel verstion to 2.3.5
|
Many modified files have format voilations. |
| throw new SeatunnelException(SeatunnelErrorEnum.ILLEGAL_STATE, e.getMessage()); | ||
| } | ||
| @PostMapping("/execute") | ||
| @ApiOperation(value = "Execute synchronization tasks", httpMethod = "Post") |
There was a problem hiding this comment.
httpMethod = "Post" should be changed to httpMethod = "POST"
|
@Jetiaime are you still working on this PR? can you please rebase this PR with latest code |
|
Outdated pull request. |
Purpose of this pull request
This PR adds the JobExecutor Delete functions.
It work like this: If the Job haven't been completed, cancel it in the engine, and then delete the restored conf file if it existed. Then delete it in the db.
I just simplely remove the record from db, and cancel the job in the engine, so it will not be removed if the record has been write into the sink. And I add some helpful functions like
isCompelete,jobStorePathfor simplify the code. The Metric Part is been repeated, I think there are some elegant ways to rewrite it.It's my first pr, please feel free to comment and give me some suggestion or advices.
Check list
New License Guide