Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand DAO Dashboard #506

Closed
10 tasks done
peterjurco opened this issue Nov 28, 2024 · 7 comments
Closed
10 tasks done

Rebrand DAO Dashboard #506

peterjurco opened this issue Nov 28, 2024 · 7 comments

Comments

@peterjurco
Copy link
Collaborator

peterjurco commented Nov 28, 2024

Debts

  • Replace the Help tooltip in the New Proposal modal with an external link to docs (PR)
  • Remove code temporarily added in [Rebrand Proposals table #499] and [Rebrand Proposal details #502] (PR)
  • Fix console errors (PR)
  • Update text in the modals (UX/UI task)
  • Update design of the "This proposal is potentially malicious." warning (design, PR)
  • Update styles of unconnected state of the Proposal details page (UX/UI task)
  • Adjust Vote states after they are updated in the design (UX/UI task)
  • Remove unused code (unused icons, CSS variables, BorderedBox component ... )
  • Connect Wallet button might be fitted into the header (UX/UI task)
  • Fix 404 page breakpoints (design)
@peterjurco
Copy link
Collaborator Author

@PrenaamD The every point from the ticket was done in a separate PR, all of them mentioning this ticket so you should see it here ⤴

@PrenaamD
Copy link
Collaborator

@peterjurco it seems that the "voted for/against" icon is not displayed

Image

I am testing locally by reusing the code from this commit Add testing capabilities

I will be posting feedback progressively

@PrenaamD
Copy link
Collaborator

Regarding the Modals text, It should be "How many API3 tokens would you like to stake?" according to design instead of "How many tokens would you like to stake?"
Same applies to

  • How many tokens would you like to unstake
  • How many tokens would you like to withdraw/deposit

@peterjurco
Copy link
Collaborator Author

it seems that the "voted for/against" icon is not displayed

Good catch. I accidentally removed those icons in the cleanup PR. I will be adding the fixes from your review to the fixes-after-qa branch.

@peterjurco
Copy link
Collaborator Author

Regarding the Modals text, It should be "How many API3 tokens would you like to stake?" according to design instead of "How many tokens would you like to stake?"

Yeah, that's correct. I am adding "API3" prefix to those modal titles

@PrenaamD
Copy link
Collaborator

I will be posting feedback progressively

Done.

@peterjurco
Copy link
Collaborator Author

@PrenaamD both issues you uncovered above have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants