Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide REACT_APP_MAINNET_PROVIDER_URL env variable when building Docker image #442

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Provide REACT_APP_MAINNET_PROVIDER_URL env variable when building Docker image #442

merged 1 commit into from
Apr 9, 2024

Conversation

mcoetzee
Copy link
Collaborator

@mcoetzee mcoetzee commented Apr 8, 2024

Closes #439

What does this change?

  • builds the Docker image with the REACT_APP_MAINNET_PROVIDER_URL env variable through the use of a build arg
  • updates documentation

@mcoetzee mcoetzee self-assigned this Apr 8, 2024
@mcoetzee mcoetzee requested review from dcroote and Siegrift April 8, 2024 15:35
@mcoetzee mcoetzee changed the title Provide REACT_APP_MAINNET_RPC_URL env variable when building Docker image Provide REACT_APP_MAINNET_PROVIDER_URL env variable when building Docker image Apr 8, 2024
dcroote
dcroote approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally using the updated Dockerfile and instructions and it worked smoothly 👍

@mcoetzee mcoetzee merged commit c0fed95 into main Apr 9, 2024
6 checks passed
@mcoetzee mcoetzee deleted the docker-build-arg branch April 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

@Siegrift Siegrift Awaiting requested review from Siegrift

Assignees

@mcoetzee mcoetzee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run prebuilt docker image
2 participants
@mcoetzee @dcroote