Rebrand Proposal details #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjurco
force-pushed
the
461/rebrand-proposals-table
branch
from
f94a4df to
65ea306
Compare
peterjurco
force-pushed
the
463/rebrand-proposal-details
branch
from
b580234 to
6478b1c
Compare
Anboias
requested changes
Nov 28, 2024
src/pages/proposal-commons/proposal-details/proposal-details.module.scss
Show resolved
Hide resolved
src/pages/proposal-commons/proposal-details/proposal-details.module.scss
Outdated
Show resolved
Hide resolved
peterjurco
force-pushed
the
463/rebrand-proposal-details
branch
from
6478b1c to
db1fe5a
Compare
Merged
|
After the merge of #500 and further thoughts I switched all success and error icons into react components. |
peterjurco
force-pushed
the
463/rebrand-proposal-details
branch
from
5e3c679 to
85dbf70
Compare
mcoetzee
approved these changes
Dec 5, 2024
peterjurco
added a commit
that referenced
this pull request
Feb 20, 2025
* Rebrand proposal details * Add testing capabilities * Fixes after the review * Use react components for error & success icons * Use useId() * Rename 'Target Address' to 'Target Contract Address'
bbenligiray
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Rebrand proposal details * Add testing capabilities * Fixes after the review * Use react components for error & success icons * Use useId() * Rename 'Target Address' to 'Target Contract Address'
bbenligiray
added a commit
that referenced
this pull request
Mar 3, 2025
* Have renovate ignore api3-dao * Bump packages and update Actions workflow (#473) * Bump packages and update Actions workflow * Revert back to Node.js 16 * Update docker/build-push-action action to v6 (#484) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @typechain/ethers-v5 to v11 (#421) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency prettier to v3 * Prettier * Add prettier:check * Require lint to pass prettier check * Update dependency cypress to v13 * Rol @types/node back to v16 * Rebrand DAO Dashboard - Colors & fonts setup (#458) * Add new color variables * Set up new fonts * Add breakpoints * Add rebrand branch to CI schedule * Fix description font styles * Rebrand page layout (#466) * Update background * Update logo * Update navigation bar * Update Connect button * Update desktop menu * Add External Links * Update layout dimensions * Update footer * Add theme prop to button component * Update error reporting notice * Update account dropdown * Update mobile menu * Fix unit test * Fix CY tests * Fixes after the review * Fix navigation height * Fix issues on the very small screens * Disable scrolling when mobile menu is open * min width for connect button * Use ExternalLink instead of Button for links * Update connected network in the mobile menu * Layout fixes (#494) * The layout fix (footer not stretched to the bottom) * History icon fix * Add menu hover & active states * Rebrand staking page (#474) * Misc additions * Update page header style * Update radial chart * Update Staking page * Move tooltips to own column * Style card title * Correct Connect Wallet info icon size * Correct Connect Wallet box button * Adjust card gap * Add secondary-neutral button variant * Add gradient border to unstaking card * Remove unnecesary global classes and fine-tune unstake panel * Refactor button variants * Adjust staking panel actions buttons * Fix Cy tests * Use data-testid instead of data-cy * Update pending staking card * Fix button unclickable bug * Rebrand tooltips (#488) * Update default tooltip * Update items tooltip * Fix staking pool table tooltips offset * Fix unchecked style * Rebrand Governance page (#496) * Rebrand Governance page * Fix CY test * Update header to <h1> * Rebrand modals (#495) * Remove unnecessary button wrapper * Update Modal component * Add button tertiary variant * Add button text-blue variant * Adapt Input component * Update Deposit modal * Update Withdraw/Stake/Unstake modals * Update Unstake Confirm modal * Update Unsupported Network modal * Self review * Show primary buttons first on mobile * Adapt to Button component without wrapper * Update account dropdown (#505) * Update Account dropdown * Apply background only when dropdown is open * Rebrand New Proposal modal (#500) * Update New Proposal modal body and labels * Refactor AutosizeInput component * Implement Textarea Input component * Final adjustments New Proposal modal * Rename AutosizeInput to Input * Remove old textarea component and update error border color * Separate TextareaInput into Input and Textarea * Rebrand Proposals table (#499) * Rebrand Proposals table * Add testing capabilities * Self review (fixing some colors) * Update Tag cursor * Rename Tag to ProposalTag * Rebrand History page (#501) * Rebrand Proposals table * Add testing capabilities * Self review (fixing some colors) * Update Tag cursor * Rebrand History page * Rename Tag to ProposalTag * Rebrand Unstake banner (#507) * Rebrand unstake banner * Move two line design to lower breakpoint * Add cookie consent logic (#508) * Add Checkbox component * Update Notice banner and align logic with Market * Add Privacy Settings modal * Fix Cypress tests * Initialize analytics and sentry * Add additional check for sentry init * Prevent default on external link click * Revert "Prevent default on external link click" This reverts commit 7c2f4a6. * Stop propagation of external link in privacy modal * Omit target and rel props * Update banner text * Display proposal title in two lines on non-desktop screens (#512) * Change Help tooltip to external link in the New Proposal modal (#515) * Change Help tooltip to external link in the New proposal modal * Fix uncentered modal title * Fix console errors (#516) * Use camelCase in SVG element prop names when they are used as react components * Add forgotten key prop * Do not pass incorrect props to input & textarea * Rebrand Proposal details (#502) * Rebrand proposal details * Add testing capabilities * Fixes after the review * Use react components for error & success icons * Use useId() * Rename 'Target Address' to 'Target Contract Address' * Add 404 page (#510) * Update NotFound page * Add Proposal page 404 redirect * Corrections * Return not found page for undecoded proposal * Add hideHeader flag to layout * Update CTA label * Use BaseLayout * Remove test code (#517) * Rebrand Governance page modals (#509) * Adapt Input component to small size * Update Delegate modal * Update Delegation action modal * Update Undelegate confirmation modal * Update Vot on proposal modal * Shorten class names * Remove value=undefined * Style the Malicious script warning (#518) * Update DAO modals (#522) * Update Unsupported chain modal * Update delegate modals * Update staking modals * Add UI for disconnected state of the proposal page (#523) Add disconnected proposal page * Fix breakpoints on 404 page (#526) * Adjust vote status when voted by delegate (#524) * Adjust vote status when voted by delegate * Update upload-artifact to v4 * Move connect button to the navigation bar on small screens (#525) * Move Connect button to navigation bar also on small screens * More explicit condition * Fix failing cypress test * Add privacy links & copyright to the footer (#527) * Add privacy links & copyright to the footer * Put links into utils file * Remove unused import * Rebrand toast messages (#519) * Update Button component * Preparatory changes * Update Toasts style * Update Clear Storage toast * Self review * Temporary testing toasts * Use customAction and prevent clear storage toast from closing * Fix Storage btn * Keep bg colour when autoClose is false * Remove testing code * Cleanup after the rebrand (#529) * Remove unused button styles * Remove unused BorderedBox component * Remove old breakpoints * Remove unused colors * Remove unused global styles and images * Fix cy test * Fixes after QA (#530) * Return voter status icons * tokens -> API3 tokens * Remove Tracker & Forum external links (#532) * Remove Tracker & Forum external links * Fix CY tests * Fix formatting after prettier update * Remove leftovers * Disable link checking of fleek deployments * Update favicon (#534) * Link DAO docs and not regular docs * Do not link Api3 Market * Remove obsolete market icon * Fix Cypress test --------- Co-authored-by: Derek Croote <dcroote@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peter Jurčo <62913177+peterjurco@users.noreply.github.com> Co-authored-by: Bogdan Iasinovschi <biasinovschi@gmail.com> Co-authored-by: peterjurco <petrojurco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461
What does this change?
How to test it?
src/chain-data/context.tsxtest-proposals.jsonfile to simulate different proposal statesScreenshot