Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump airnode to v0.15.0 #417

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Bump airnode to v0.15.0 #417

merged 4 commits into from
Feb 14, 2025

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Feb 14, 2025

A downstream fix for api3dao/data-feed-reader-example#199 since airnode-feed is pulling in airnode-node v0.14.2 which is pulling in commons ^0.5.0

image

@dcroote dcroote self-assigned this Feb 14, 2025
@dcroote
Copy link
Contributor Author

dcroote commented Feb 14, 2025

The weird CI failures (also happening in renovate PRs 1 and 2):

   > [build 8/8] RUN pnpm run --recursive build:
  0.899 Scope: 4 of 5 workspace projects
  0.902 packages/airnode-feed build$ tsc --project tsconfig.build.json
  0.910 packages/airnode-feed build: sh: 1: tsc: not found
  0.911 /app/packages/airnode-feed:
  0.911  ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @api3/airnode-feed@2.1.0 build: `tsc --project tsconfig.build.json`
  0.911 spawn ENOENT
  0.912  WARN   Local package.json exists, but node_modules missing, did you mean to install?

occur because pnpm behavior changed and the Dockerfile command:

RUN npm install -g pnpm

installs the latest pnpm and not the one from package.json.

Consequently this PR also updates the dockerfile to install the pnpm version in package.json.

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!

@dcroote dcroote merged commit bdd466e into main Feb 14, 2025
5 checks passed
@dcroote dcroote deleted the airnode-bump branch February 14, 2025 15:28
@dcroote
Copy link
Contributor Author

dcroote commented Feb 14, 2025

Sure thing (and as confirmation the other renovate PRs are now passing).

No rush, but would you be able to release? Alternatively I could try (not entirely sure if I have the permissions) if you had thoughts on minor vs. patch.

@Siegrift
Copy link
Collaborator

Alternatively I could try (not entirely sure if I have the permissions) if you had thoughts on minor vs. patch.

It should be a minor. Although I don't see the point in doing the release now.

@dcroote
Copy link
Contributor Author

dcroote commented Feb 16, 2025

Airnode v0.14 being a part of signed-api is causing problems in other packages, hence why I think we should release.

@Siegrift
Copy link
Collaborator

I see. We don't have yet reports of this being a problem in here, but there is no reason to wait. I'll do a release now. Should be as simple as https://github.com/api3dao/signed-api/blob/main/README.md#versioning-and-release

@Siegrift Siegrift mentioned this pull request Feb 17, 2025
@dcroote
Copy link
Contributor Author

dcroote commented Feb 17, 2025

Thanks @Siegrift !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants