Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts everywhere #421

Closed
wants to merge 1 commit into from
Closed

Add ts everywhere #421

wants to merge 1 commit into from

Conversation

Siegrift
Copy link
Collaborator

When I ran pnpm run create-release:npm minor the script failed on TSC checks because tsc was unavailable in some subpackages. I'm adding it expllicitely in this PR so that I can proceed with #417 (comment)

@Siegrift Siegrift self-assigned this Feb 17, 2025
@Siegrift Siegrift requested a review from dcroote February 17, 2025 07:10
@Siegrift
Copy link
Collaborator Author

Also, I guess we'll do the release after #420

@bdrhn9
Copy link
Contributor

bdrhn9 commented Feb 17, 2025

After pnpm run build on the root of the project, the current main branch worked well to me. Can you try?

@Siegrift
Copy link
Collaborator Author

After pnpm run build on the root of the project, the current main branch worked well to me. Can you try?

Mhh, strange... It works for me now as well. I also tried pruning all of the node_modules and did a clean install and the command worked... I am not sure why I got the error before...

@Siegrift Siegrift closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants