Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity "SametSite" error #713

Open
wkande opened this issue Mar 19, 2024 · 7 comments
Open

Clarity "SametSite" error #713

wkande opened this issue Mar 19, 2024 · 7 comments

Comments

@wkande
Copy link
Member

wkande commented Mar 19, 2024

T wants to add Clarity to the docs.

It starts with this script:

<script type="text/javascript">
    (function(c,l,a,r,i,t,y){
        c[a]=c[a]||function(){(c[a].q=c[a].q||[]).push(arguments)};
        t=l.createElement(r);t.async=1;t.src="https://www.clarity.ms/tag/"+i;
        y=l.getElementsByTagName(r)[0];y.parentNode.insertBefore(t,y);
    })(window, document, "clarity", "script", "lbhxsuq10f");
</script>

But that produces an err on some browses. T said to adding the same type of cookie banner (as the Market's) to the docs might be needed.

I think we need to add the cookies banner for users reading the docs- Bogdan & peter can you help warren out with this? It should be the same thing that's on the market

It would be some time before I have availability to do this. If someone else wishes to pick this up and test their skill please do.

@dcroote
Copy link
Collaborator

dcroote commented Mar 20, 2024

But that produces an err on some browses.

Can you say which browsers do / don't work, as far as you're aware?

@wkande
Copy link
Member Author

wkande commented Mar 20, 2024

See this slack thread: https://api3workspace.slack.com/archives/C044VBS8KA5/p1709571118161259

I am not convinced that we need to do the "Browser cookie management thing" to solve this issue. We had the same problem with Google analytics. Namely the SameSite problem. See this slack thread: https://api3workspace.slack.com/archives/C05T16WJH6X/p1701557053610809

This is the Clarity error that is the root cause I believe.

Cookie "_clsk" does not have a proper "SameSite" attribute value.

Somehow we got this fixed for Google from research Harsha did. I have messaged him.

@wkande
Copy link
Member Author

wkande commented Mar 21, 2024

For visibility @T9991 and @gulla0

@gulla0
Copy link

gulla0 commented Mar 21, 2024

I'll check and see if I can find info on this. :-)

@T9991
Copy link
Collaborator

T9991 commented Mar 21, 2024 via email

@wkande
Copy link
Member Author

wkande commented Mar 21, 2024

We should fix this problem first. I have added a separate issue for the banner see here.

@wkande wkande changed the title Add clarity and cookie permission banner Clarity "SametSite" error Mar 21, 2024
@gulla0
Copy link

gulla0 commented Mar 21, 2024

For Microsoft Clarity, there is no option of adding the samesite attributes directly on the frontend.
I did find a couple of GitHub repos that might have some answers, let me know if these help at all.

https://github.com/GoogleChromeLabs/samesite-examples

https://github.com/GoogleChromeLabs/samesite-examples/blob/master/javascript-nodejs.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants