Merge pull request #63 from apisearch-io/fix/fixed-special-hash-character-in-search

Fixed hash character in url parameters

Author: mmoreram

package.json

@@ -1,6 +1,6 @@
 {
   "name": "apisearch",
-  "version": "0.2.30",
+  "version": "0.2.31",
   "description": "Javascript client for Apisearch.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/Http/AxiosClient.ts

@@ -87,7 +87,7 @@ export class AxiosClient extends Client implements HttpClient {
                 ...{
                     token: credentials.token,
                 },
-            }),
+            }).replace(/#/g, '%23'),
         };
 
         if (typeof this.cancelToken[url] !== "undefined") {

test/Functional/Apisearch/Error.test.ts

@@ -2,15 +2,16 @@ import Axios from "axios";
 import {expect} from "chai";
 import * as sinon from "sinon";
 import Apisearch from "../../../src/Apisearch";
-import {Config} from "../../../src/Config/Config";
-import {ConnectionError} from "../../../src/Error/ConnectionError";
-import {InvalidTokenError} from "../../../src/Error/InvalidTokenError";
-import {ResourceExistsError} from "../../../src/Error/ResourceExistsError";
-import {ResourceNotAvailableError} from "../../../src/Error/ResourceNotAvailableError";
 import {UnknownError} from "../../../src/Error/UnknownError";
 import {IndexUUID} from "../../../src/Model/IndexUUID";
-import {Query} from "../../../src/Query/Query";
 import FunctionalTest from "./FunctionalTest";
+import {
+    Config,
+    ConnectionError,
+    InvalidTokenError,
+    Query, ResourceExistsError,
+    ResourceNotAvailableError
+} from "../../../src";
 
 afterEach(() => {
     sinon.restore();

test/Functional/Apisearch/FunctionalTest.ts

@@ -1,5 +1,5 @@
 import Apisearch from "../../../src/Apisearch";
-import {HttpRepository} from "../../../src/Repository/HttpRepository";
+import {HttpRepository} from "../../../src";
 
 /**
  * Apisearch class
@@ -15,10 +15,10 @@ export default class FunctionalTest {
         return Apisearch.createRepository({
             app_id: "789437438test",
             index_id: "default",
+            token: "0e4d75ba-c640-44c1-a745-06ee51db4e93",
             options: {
                 endpoint: "http://localhost:8000",
             },
-            token: "0e4d75ba-c640-44c1-a745-06ee51db4e93",
         });
     }
 }

test/Functional/Apisearch/Query.test.ts

@@ -227,4 +227,25 @@ describe('Apisearch', () => {
             });
     });
 
+
+    it('should be able to work with strange characters', async() => {
+        const items = [
+            Item.create(ItemUUID.createByComposedUUID('1~item'), {
+                'name': "strange # character"
+            }, {}, {
+                'name': 'strange # character'
+            }),
+        ];
+
+        repository.addItems(items);
+        await repository.flush();
+
+        await repository
+            .query(Query
+                .create('strange # char')
+            )
+            .then(result => {
+                expect(result.getFirstItem().getUUID().getId()).to.be.equal("1");
+            });
+    });
 });