-
Notifications
You must be signed in to change notification settings - Fork 2.7k
change tracking behaviour for QueryInfo
#12647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.0
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 624bf71 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
size-limit report 📦
|
ea5945f
to
6960e06
Compare
@@ -4170,47 +4170,6 @@ describe("ApolloClient", () => { | |||
expect(timesFired).toBe(2); | |||
}); | |||
|
|||
it("should not error on a stopped query()", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading #4409 it seems to me that this tests to prevent something that could be achieved in a very old iteration of the Query
component or by calling QueryManager
functions like stopQuery
from userland code - but stopQuery
since has been removed and we consider QueryManager
an internal API.
=> I think it's fine to remove this test.
No description provided.