Remove withBuiltInDefinitions() and add flag to dump scalar definitions in SDL
#6389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 9b3a256e03ffec9054435898 |
martinbonnin
commented
Feb 19, 2025
Comment on lines
-21
to
-28
| @Test | ||
| fun typeRedefinitionInspectionIsIgnored() { | ||
| val sdlSchema = File("${CWD}/test-fixtures/sdl/type_redefinitions.graphqls") | ||
|
|
||
| checkExpected(sdlSchema) { | ||
| it.parseAsGQLDocument().getOrThrow().withBuiltinDefinitions().toSDL(" ") | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not 100% sure what this was testing. Removed it. Might add new ones later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out removing the scalar creates a lot of complexity in the code. It's just easier to have a SDL schema matching 1:1 with the introspection. This is somewhat discouraged by the spec but I think this is just that the spec is mostly written with backend frameworks in mind and didn't consider clients wanting to validate operations, etc...