Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch link widget to extend apos-link-widgets #89

Open
abea opened this issue Jul 18, 2019 · 1 comment
Open

Switch link widget to extend apos-link-widgets #89

abea opened this issue Jul 18, 2019 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@abea
Copy link
Contributor

abea commented Jul 18, 2019

https://github.com/apostrophecms/apostrophe-open-museum/blob/23312897a4113a3ea7e9e3d9097ec2b4ce613b89/lib/modules/link-widgets/lib/schema.js#L1-L64

Any objection to changing this to extending apos-link-widgets: https://github.com/apostrophecms/apostrophe-link-widgets/blob/master/index.js? Or maybe not extend, but use the existing schema from that module. The schema names are all the same, plus some in apos-link-widgets. We could turn the Open Museum link widgets into an example of defining the schema by pulling it out of an existing module. It also lets us highlight more ready-made modules.

CC @stuartromanek @boutell @grdunn

@abea abea added the question Further information is requested label Jul 18, 2019
@stuartromanek
Copy link

No objection, as long as testing the transition is all good and works

@abea abea self-assigned this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants