feat: Determine chromedriver version from the /status API output #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking appium/appium#20924 |
KazuCocoa
reviewed
Jan 23, 2025
| await this.jwproxy.command('/session', 'POST', sessionCaps) | ||
| ); | ||
| this.log.prefix = generateLogPrefix(this, this.jwproxy.sessionId); | ||
| this.changeState(Chromedriver.STATE_ONLINE); | ||
| return capabilities; | ||
| return _.has(response, 'capabilities') ? response.capabilities : response; |
KazuCocoa
reviewed
Jan 24, 2025
KazuCocoa
approved these changes
Jan 24, 2025
| const chromeOptions = getCapValue(this.capabilities, 'chromeOptions', {}); | ||
| if (chromeOptions.w3c === false) { | ||
| const isOperaDriver = _.includes(this._onlineStatus?.message, 'OperaDriver'); | ||
| const chromeOptions = getCapValue(this.capabilities, 'chromeOptions'); |
There was a problem hiding this comment.
Do you think it would be nice to add ms:edgeOptions for MSEdge as well?
MSEdge supports chormeOptions naming still, so I don't have any strong opinion for this. I don't remember well, but probably edge prior edgeOptions than chormeOptions
There was a problem hiding this comment.
edgeOptions map does not contain the w3c flag, so I assume this logic could remain unchanged for now: https://learn.microsoft.com/de-de/microsoft-edge/webdriver-chromium/capabilities-edge-options
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
## [7.0.0](v6.1.16...v7.0.0) (2025-01-24) ### ⚠ BREAKING CHANGES * The detectWebDriverProtocol method of the Chromedriver class has been removed * The desiredProtocol property of the Chromedriver class has been renamed to _desiredProtocol * The driverVersion property of the Chromedriver has been changed to a getter ### Features * Determine chromedriver version from the /status API output ([#456](#456)) ([797c8cc](797c8cc))
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
detectWebDriverProtocolmethod of the Chromedriver class has been removedBREAKING CHANGE: The
desiredProtocolproperty of the Chromedriver class has been renamed to_desiredProtocolBREAKING CHANGE: The
driverVersionproperty of the Chromedriver has been changed to a getter