Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code style #87

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix: code style #87

merged 2 commits into from
Apr 12, 2024

Conversation

hakusai22
Copy link
Contributor

  1. Remove invalid import.
  2. Remove invalid exception thrown.
  3. Test Case add Assertions.assertNotNull(key).
  4. Modify method comments in a unified style.
  5. Map<String, Object> root = null; Variable 'root' initializer 'null' is redundant.

alexanderjordanbaker
alexanderjordanbaker approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@alexanderjordanbaker alexanderjordanbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@alexanderjordanbaker alexanderjordanbaker merged commit 084f4f2 into apple:main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderjordanbaker alexanderjordanbaker alexanderjordanbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hakusai22 @alexanderjordanbaker