Skip to content

Commit 7f18d59

Browse files
committed
Bug fix, the blob request attempt count is now incremented for all errors except response code 429.
1 parent a248134 commit 7f18d59

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

fdbrpc/BlobStore.actor.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,10 @@ ACTOR Future<Reference<HTTP::Response>> doRequest_impl(Reference<BlobStoreEndpoi
413413
.detail("ThisTry", thisTry)
414414
.suppressFor(5, true);
415415

416+
// If r is not valid or not code 429 then increment the try count. 429's will not count against the attempt limit.
417+
if(!r || r->code != 429)
418+
++thisTry;
419+
416420
// We will wait delay seconds before the next retry, start with nextRetryDelay.
417421
double delay = nextRetryDelay;
418422
// Double but limit the *next* nextRetryDelay.

0 commit comments

Comments
 (0)