Skip to content

Commit b02cefa

Browse files
Fix merge problem
1 parent 27ce3f6 commit b02cefa

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DefaultHttpLoadBalancerFactory.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -368,23 +368,23 @@ public Single<StreamingHttpResponse> request(final StreamingHttpRequest request)
368368

369369
return Single.defer(() -> {
370370
final RequestTracker theTracker = new AtMostOnceDeliveryRequestTracker(tracker);
371-
final long startTime = theTracker.beforeStart();
371+
final long startTime = theTracker.beforeRequestStart();
372372

373373
return delegate.request(request)
374374
.liftSync(new BeforeFinallyHttpOperator(new TerminalSignalConsumer() {
375375
@Override
376376
public void onComplete() {
377-
theTracker.onSuccess(startTime);
377+
theTracker.onRequestSuccess(startTime);
378378
}
379379

380380
@Override
381381
public void onError(final Throwable throwable) {
382-
theTracker.onError(startTime, errorClassFunction.apply(throwable));
382+
theTracker.onRequestError(startTime, errorClassFunction.apply(throwable));
383383
}
384384

385385
@Override
386386
public void cancel() {
387-
theTracker.onError(startTime, ErrorClass.CANCELLED);
387+
theTracker.onRequestError(startTime, ErrorClass.CANCELLED);
388388
}
389389
}, /*discardEventsAfterCancel*/ true))
390390

@@ -397,7 +397,7 @@ public void cancel() {
397397
final ErrorClass eClass = peerResponseErrorClassifier.apply(response);
398398
if (eClass != null) {
399399
// The onError is triggered before the body is actually consumed.
400-
theTracker.onError(startTime, eClass);
400+
theTracker.onRequestError(startTime, eClass);
401401
}
402402
return response;
403403
})
@@ -453,21 +453,21 @@ private AtMostOnceDeliveryRequestTracker(final RequestTracker original) {
453453
}
454454

455455
@Override
456-
public long beforeStart() {
457-
return original.beforeStart();
456+
public long beforeRequestStart() {
457+
return original.beforeRequestStart();
458458
}
459459

460460
@Override
461-
public void onSuccess(final long beforeStartTimeNs) {
461+
public void onRequestSuccess(final long beforeStartTimeNs) {
462462
if (doneUpdater.compareAndSet(this, 0, 1)) {
463-
original.onSuccess(beforeStartTimeNs);
463+
original.onRequestSuccess(beforeStartTimeNs);
464464
}
465465
}
466466

467467
@Override
468-
public void onError(final long beforeStartTimeNs, final ErrorClass errorClass) {
468+
public void onRequestError(final long beforeStartTimeNs, final ErrorClass errorClass) {
469469
if (doneUpdater.compareAndSet(this, 0, 1)) {
470-
original.onError(beforeStartTimeNs, errorClass);
470+
original.onRequestError(beforeStartTimeNs, errorClass);
471471
}
472472
}
473473
}

servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/ErrorClass.java

+4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ public enum ErrorClass {
2424
* Failures related to locally enforced timeouts that prevent session establishment with the peer.
2525
*/
2626
LOCAL_ORIGIN_TIMEOUT(true),
27+
/**
28+
* Failures related to connection establishment.
29+
*/
30+
LOCAL_ORIGIN_CONNECT_FAILED(true),
2731

2832
/**
2933
* Failures caused locally, these would be things that failed due to an exception locally.

0 commit comments

Comments
 (0)