Skip to content

Commit f185e02

Browse files
committed
idels feedback
1 parent d2f79bf commit f185e02

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/DefaultHttpLoadBalancerFactory.java

+13-4
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,10 @@ public FilterableStreamingHttpLoadBalancedConnection toLoadBalancedConnection(
134134
}
135135
}
136136

137+
if (hostHealthIndicator == null) {
138+
return HttpLoadBalancerFactory.super.toLoadBalancedConnection(connection, concurrencyController, context);
139+
}
140+
137141
return new DefaultHttpLoadBalancedConnection(connection, concurrencyController,
138142
errorClassFunction, peerResponseErrorClassifier, hostHealthIndicator);
139143
}
@@ -357,11 +361,11 @@ public <T> Publisher<? extends T> transportEventStream(final HttpEventKey<T> eve
357361

358362
@Override
359363
public Single<StreamingHttpResponse> request(final StreamingHttpRequest request) {
360-
return Single.defer(() -> {
361-
if (tracker == null) {
362-
return delegate.request(request).shareContextOnSubscribe();
363-
}
364+
if (tracker == null) {
365+
return delegate.request(request).shareContextOnSubscribe();
366+
}
364367

368+
return Single.defer(() -> {
365369
final RequestTracker theTracker = new AtMostOnceDeliveryRequestTracker(tracker);
366370
final long startTime = theTracker.beforeStart();
367371

@@ -430,6 +434,11 @@ public StreamingHttpRequest newRequest(final HttpRequestMethod method, final Str
430434
return delegate.newRequest(method, requestTarget);
431435
}
432436

437+
@Override
438+
public String toString() {
439+
return delegate.toString();
440+
}
441+
433442
private static final class AtMostOnceDeliveryRequestTracker implements RequestTracker {
434443

435444
private static final AtomicIntegerFieldUpdater<AtMostOnceDeliveryRequestTracker> doneUpdater =

0 commit comments

Comments
 (0)