Enhance testing of the server-side control flow (#2377)

Motivation:

Cover a few more use-cases to increase confidence in server-side control flow behavior.

Modifications:

- Add `ServerPipelineControlFlowTest`;
- Add utilities for easier setup of debugging options for client/server builder;

Result:

More tests for the server-side control flow.

Author: idelpivnitskiy

servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/BuilderUtils.java

@@ -0,0 +1,87 @@
+/*
+ * Copyright © 2022 Apple Inc. and the ServiceTalk project authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.servicetalk.http.netty;
+
+import io.servicetalk.http.api.HttpExecutionStrategy;
+import io.servicetalk.http.api.HttpProtocolConfig;
+import io.servicetalk.http.api.HttpServerBuilder;
+import io.servicetalk.http.api.SingleAddressHttpClientBuilder;
+import io.servicetalk.transport.api.ExecutionContext;
+import io.servicetalk.transport.api.ExecutionStrategy;
+import io.servicetalk.transport.api.HostAndPort;
+import io.servicetalk.transport.api.ServerContext;
+
+import java.net.InetSocketAddress;
+
+import static io.servicetalk.http.netty.HttpProtocol.toConfigs;
+import static io.servicetalk.http.utils.HttpLifecycleObservers.logging;
+import static io.servicetalk.logging.api.LogLevel.TRACE;
+import static io.servicetalk.transport.netty.internal.AddressUtils.localAddress;
+import static io.servicetalk.transport.netty.internal.AddressUtils.serverHostAndPort;
+
+final class BuilderUtils {
+
+    private BuilderUtils() {
+        // No instances
+    }
+
+    static HttpServerBuilder newLocalServer(ExecutionContext<? extends ExecutionStrategy> ctx,
+                                            HttpProtocol... protocols) {
+        return newLocalServerWithConfigs(ctx, toConfigs(protocols));
+    }
+
+    static HttpServerBuilder newLocalServerWithConfigs(ExecutionContext<? extends ExecutionStrategy> ctx,
+                                                       HttpProtocolConfig... protocols) {
+        HttpServerBuilder builder = HttpServers.forAddress(localAddress(0))
+                .ioExecutor(ctx.ioExecutor())
+                .executor(ctx.executor())
+                .bufferAllocator(ctx.bufferAllocator())
+                .executionStrategy(HttpExecutionStrategy.from(ctx.executionStrategy()))
+                .enableWireLogging("servicetalk-tests-wire-logger", TRACE, Boolean.TRUE::booleanValue)
+                .lifecycleObserver(logging("servicetalk-tests-lifecycle-observer-logger", TRACE));
+        if (protocols.length > 0) {
+            builder.protocols(protocols);
+        }
+        return builder;
+    }
+
+    static SingleAddressHttpClientBuilder<HostAndPort, InetSocketAddress> newClient(
+            ServerContext serverContext,
+            ExecutionContext<? extends ExecutionStrategy> ctx,
+            HttpProtocol... protocols) {
+        return newClientWithConfigs(serverContext, ctx, toConfigs(protocols));
+    }
+
+    static SingleAddressHttpClientBuilder<HostAndPort, InetSocketAddress> newClientWithConfigs(
+            ServerContext serverContext,
+            ExecutionContext<? extends ExecutionStrategy> ctx,
+            HttpProtocolConfig... protocols) {
+
+        SingleAddressHttpClientBuilder<HostAndPort, InetSocketAddress> builder =
+                HttpClients.forSingleAddress(serverHostAndPort(serverContext))
+                        .ioExecutor(ctx.ioExecutor())
+                        .executor(ctx.executor())
+                        .bufferAllocator(ctx.bufferAllocator())
+                        .executionStrategy(HttpExecutionStrategy.from(ctx.executionStrategy()))
+                        .enableWireLogging("servicetalk-tests-wire-logger", TRACE, Boolean.TRUE::booleanValue)
+                        .appendClientFilter(new HttpLifecycleObserverRequesterFilter(
+                                logging("servicetalk-tests-lifecycle-observer-logger", TRACE)));
+        if (protocols.length > 0) {
+            builder.protocols(protocols);
+        }
+        return builder;
+    }
+}

servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/GracefulConnectionClosureHandlingTest.java

@@ -95,7 +95,7 @@
 import static io.servicetalk.utils.internal.PlatformDependent.throwException;
 import static java.lang.Integer.parseInt;
 import static java.lang.String.valueOf;
-import static java.nio.charset.StandardCharsets.UTF_8;
+import static java.nio.charset.StandardCharsets.US_ASCII;
 import static java.util.Arrays.asList;
 import static java.util.Objects.requireNonNull;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -110,7 +110,8 @@ class GracefulConnectionClosureHandlingTest {
     private static final Logger LOGGER = LoggerFactory.getLogger(GracefulConnectionClosureHandlingTest.class);
     private static final Collection<Boolean> TRUE_FALSE = asList(true, false);
 
-    static final HttpStreamingSerializer<String> RAW_STRING_SERIALIZER = stringStreamingSerializer(UTF_8, hdr -> { });
+    static final HttpStreamingSerializer<String> RAW_STRING_SERIALIZER =
+            stringStreamingSerializer(US_ASCII, hdr -> { });
 
     @RegisterExtension
     static final ExecutionContextExtension SERVER_CTX =

servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/HttpProtocol.java

@@ -18,8 +18,8 @@
 import io.servicetalk.http.api.HttpProtocolConfig;
 import io.servicetalk.http.api.HttpProtocolVersion;
 
+import java.util.Arrays;
 import java.util.Collection;
-import java.util.stream.Collectors;
 
 import static io.servicetalk.http.api.HttpProtocolVersion.HTTP_1_1;
 import static io.servicetalk.http.api.HttpProtocolVersion.HTTP_2_0;
@@ -40,6 +40,10 @@ enum HttpProtocol {
     }
 
     static HttpProtocolConfig[] toConfigs(Collection<HttpProtocol> protocols) {
-        return protocols.stream().map(p -> p.config).collect(Collectors.toList()).toArray(new HttpProtocolConfig[] {});
+        return protocols.stream().map(p -> p.config).toArray(HttpProtocolConfig[]::new);
+    }
+
+    static HttpProtocolConfig[] toConfigs(HttpProtocol[] protocols) {
+        return Arrays.stream(protocols).map(p -> p.config).toArray(HttpProtocolConfig[]::new);
     }
 }