Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadBalancer wire the tracker on the host layers with the request flow #2816

Merged
merged 15 commits into from
Feb 1, 2024
Merged

LoadBalancer wire the tracker on the host layers with the request flow #2816

merged 15 commits into from
Feb 1, 2024

Conversation

tkountis
Copy link
Contributor

@tkountis tkountis commented Jan 26, 2024 •
edited
Loading

Motivation

In order for the new load balancer features to work, the health indicators need to be wired as request trackers on the request flow.

Modification

  • Added additional configuration options in the DefaultHttpLoadBalancerFactory to support error classifications. Feature only useful to load-balancers that support it.
  • When the Context is available and a request-tracker is present in it, the request flow is now enriched with additional logic to track the state and feed it to the request-tracker.

@tkountis tkountis self-assigned this Jan 26, 2024
bryce-anderson
bryce-anderson reviewed Jan 29, 2024
View reviewed changes
idelpivnitskiy
idelpivnitskiy requested changes Jan 31, 2024
View reviewed changes
bryce-anderson
bryce-anderson approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@bryce-anderson bryce-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkountis!

idelpivnitskiy
idelpivnitskiy reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more comments, then lgtm:

@tkountis @idelpivnitskiy
Update servicetalk-http-netty/src/main/java/io/servicetalk/http/netty…
7754d58 
…/DefaultHttpLoadBalancerFactory.java

Co-authored-by: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
@tkountis tkountis changed the title LoadBalancer wire the tracker on the host and connection layers LoadBalancer wire the tracker on the host layers with the request flow Feb 1, 2024
@tkountis tkountis merged commit 11c5a3d into apple:main Feb 1, 2024
15 checks passed
@tkountis tkountis deleted the tracker-wiring branch February 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryce-anderson bryce-anderson bryce-anderson approved these changes

@idelpivnitskiy idelpivnitskiy idelpivnitskiy approved these changes

Assignees

@tkountis tkountis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkountis @bryce-anderson @idelpivnitskiy