loadbalancer: Pass connection failures to the HealthIndicator #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We can't rely on the request path to pass in connection failures because if we can't get a connection we can never add the observers. That means we need the `Host` implementation to pass it in directly. Modifications: Add two new methods to `HealthIndicator` that provide the current time and and a callback for submitting connection failures. Result: We should be able to track connection failures now and factor those into the `HealthTracker` implementations.
|
I like #2818 a bit better so I'm going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We can't rely on the request path to pass in connection failures because if we can't get a connection we can never add the observers. That means we need the
Hostimplementation to pass it in directly.Modifications:
Add two new methods to
HealthIndicatorthat provide the current time and and a callback for submitting connection failures.Result:
We should be able to track connection failures now and factor those into the
HealthTrackerimplementations.Note
See #2818 for an alternative which is substantially the same but has a somewhat better feeling organization.