Update OpenTelemetry 1.28.0 -> 1.38.0, instrumentation 1.28.0 -> 1.33.3 #3161
+69
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We're experiencing some degree of incompatibility with otel. This is happening because we're using otels alpha API's for the semconv package and they have walked on us. Modifications: Upgrade the dependency version.
bryce-anderson
changed the title
bryce-anderson
commented
Jan 9, 2025
Comment on lines
+38
to
+42
| static final HttpClientAttributesGetter<HttpRequestMetaData, HttpResponseMetaData> CLIENT_INSTANCE = | ||
| new ClientGetter(); | ||
|
|
||
| static final HttpServerAttributesGetter<HttpRequestMetaData, HttpResponseMetaData> SERVER_INSTANCE = | ||
| new ServerGetter(); |
There was a problem hiding this comment.
Note that in both of the getter types, we need these two different sub-classes because the ClientGetter and ServerGetter have some new default methods the the same signature and the java compiler doesn't know which to use.
mgodave
approved these changes
Jan 9, 2025
...try-http/src/main/java/io/servicetalk/opentelemetry/http/OpenTelemetryHttpRequestFilter.java
Outdated
Show resolved
Hide resolved
...try-http/src/main/java/io/servicetalk/opentelemetry/http/OpenTelemetryHttpRequestFilter.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jan 9, 2025
...try-http/src/main/java/io/servicetalk/opentelemetry/http/OpenTelemetryHttpRequestFilter.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We're experiencing some degree of incompatibility with otel. This is happening because we're using otels alpha API's for the semconv package and they have walked on us.
Modifications:
Upgrade the dependency versions. Note that it seems like the 1.33.3-alpha boms are using the 1.38.0 non-alpha packages, which is odd but that is why the versions for alpha and non-alpha are different.