Introduce the firstAndTail operator to the public API #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgodave
changed the title
mgodave
changed the title
mgodave
commented
Feb 7, 2025
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
mgodave
commented
Feb 7, 2025
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/StacklessCancellationException.java
Show resolved
Hide resolved
mgodave
commented
Feb 7, 2025
...cetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SubscribablePublisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/StacklessCancellationException.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/StacklessCancellationException.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SubscribablePublisher.java
Outdated
Show resolved
Hide resolved
...cetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/SubscribablePublisher.java
Outdated
Show resolved
Hide resolved
...-http-netty/src/test/java/io/servicetalk/http/netty/SpliceFlatStreamToMetaSingleTckTest.java
Outdated
Show resolved
Hide resolved
…rent/api/SubscribablePublisher.java Co-authored-by: Bryce Anderson <bl_anderson@apple.com>
…rent/api/StacklessCancellationException.java Co-authored-by: Bryce Anderson <bl_anderson@apple.com>
...alk-http-netty/src/test/java/io/servicetalk/http/netty/SpliceFlatStreamToMetaSingleTest.java
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/SpliceFlatStreamToPackedSingle.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/SpliceFlatStreamToPackedSingle.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/SpliceFlatStreamToPackedSingle.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/main/java/io/servicetalk/concurrent/api/SpliceFlatStreamToPackedSingle.java
Outdated
Show resolved
Hide resolved
mgodave
changed the title
bryce-anderson
approved these changes
Feb 14, 2025
...k-concurrent-api/src/main/java/io/servicetalk/concurrent/api/FirstAndTailToPackedSingle.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/FirstAndTailToPackedSingleTest.java
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/FirstAndTailToPackedSingleTest.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found increasing cases where the
spliceoperator can be used outside of the ST implementation and are therefore migrating it to the public API for general use. Instead of "splice" we are adopting "firstAndTail" as the public name.Previously this operator parameterized different types for the first item and the remaining which, as a result, would attempt to perform a cast inside the operator for the first element. While migrating this operator, for general usage outside of the internal http packages, I have removed this cast and made the simplifying assumption that the head and the tail of the spliced stream are of the type of the input stream.