Adopt github actions

Author: ktoso

.github/workflows/pull_request.yml

@@ -27,3 +27,7 @@ jobs:
       matrix_windows_6_0_enabled: false
       matrix_windows_nightly_6_0_enabled: false
       matrix_windows_nightly_main_enabled: false
+
+  integration-tests:
+    name: Integration tests
+    run:

.swift-format

@@ -28,7 +28,6 @@
    },
    "rules" : {
      "NoBlockComments" : false,
-     "EndOfLineComment" : false,
      "ReplaceForEachWithForLoop" : false,
 
      "AllPublicDeclarationsHaveDocumentation" : false,
@@ -71,4 +70,4 @@
      "UseWhereClausesInForLoops" : false,
      "ValidateDocumentationComments" : false
    }
- }
+ }

.swiftformat

@@ -14,4 +14,4 @@
 
 import SWIM
 
-// TODO: implement me
+// TODO: implement me

IntegrationTests/tests_01_cluster/it_Clustered_swim_suspension_reachability/main.swift

@@ -1,17 +1,18 @@
-// swift-tools-version:5.7
+// swift-tools-version:5.9
 // The swift-tools-version declares the minimum version of Swift required to build this package.
 
-import class Foundation.ProcessInfo
 import PackageDescription
 
+import class Foundation.ProcessInfo
+
 // Workaround: Since we cannot include the flat just as command line options since then it applies to all targets,
 // and ONE of our dependencies currently produces one warning, we have to use this workaround to enable it in _our_
 // targets when the flag is set. We should remove the dependencies and then enable the flag globally though just by passing it.
 let globalSwiftSettings: [SwiftSetting]
 if ProcessInfo.processInfo.environment["WARNINGS_AS_ERRORS"] != nil {
     print("WARNINGS_AS_ERRORS enabled, passing `-warnings-as-errors`")
     globalSwiftSettings = [
-        SwiftSetting.unsafeFlags(["-warnings-as-errors"]),
+        SwiftSetting.unsafeFlags(["-warnings-as-errors"])
     ]
 } else {
     globalSwiftSettings = []
@@ -23,8 +24,7 @@ var targets: [PackageDescription.Target] = [
 
     .target(
         name: "ClusterMembership",
-        dependencies: [
-        ]
+        dependencies: []
     ),
 
     .target(
@@ -59,7 +59,7 @@ var targets: [PackageDescription.Target] = [
     .testTarget(
         name: "ClusterMembershipDocumentationTests",
         dependencies: [
-            "SWIM",
+            "SWIM"
         ]
     ),
 
@@ -69,7 +69,7 @@ var targets: [PackageDescription.Target] = [
     .testTarget(
         name: "ClusterMembershipTests",
         dependencies: [
-            "ClusterMembership",
+            "ClusterMembership"
         ]
     ),
 
@@ -106,7 +106,7 @@ var targets: [PackageDescription.Target] = [
     .executableTarget(
         name: "it_Clustered_swim_suspension_reachability",
         dependencies: [
-            "SWIM",
+            "SWIM"
         ],
         path: "IntegrationTests/tests_01_cluster/it_Clustered_swim_suspension_reachability"
     ),
@@ -123,7 +123,7 @@ var dependencies: [Package.Dependency] = [
 
     // ~~~ SSWG APIs ~~~
     .package(url: "https://github.com/apple/swift-log.git", from: "1.4.0"),
-    .package(url: "https://github.com/apple/swift-metrics.git", "2.3.2" ..< "3.0.0"), // since latest
+    .package(url: "https://github.com/apple/swift-metrics.git", "2.3.2"..<"3.0.0"),  // since latest
 
     // ~~~ SwiftPM Plugins ~~~
     .package(url: "https://github.com/apple/swift-docc-plugin", from: "1.0.0"),

Package.swift

@@ -22,7 +22,7 @@ var targets: [PackageDescription.Target] = [
     .testTarget(
         name: "NoopTests",
         dependencies: [
-            "SWIM",
+            "SWIM"
         ],
         path: "Tests/NoopTests"
     ),
@@ -48,7 +48,7 @@ let package = Package(
         .executable(
             name: "SWIMNIOSampleCluster",
             targets: ["SWIMNIOSampleCluster"]
-        ),
+        )
 
     ],
 

Samples/Package.swift

@@ -13,10 +13,10 @@
 //===----------------------------------------------------------------------===//
 
 import ClusterMembership
+import Logging
+import NIO
 import SWIM
 import SWIMNIOExample
-import NIO
-import Logging
 
 struct SampleSWIMNIONode {
     let port: Int
@@ -63,10 +63,13 @@ final class SWIMNIOSampleHandler: ChannelInboundHandler {
         let change: SWIM.MemberStatusChangedEvent = self.unwrapInboundIn(data)
 
         // we log each event (in a pretty way)
-        self.log.info("Membership status changed: [\(change.member.node)] is now [\(change.status)]", metadata: [
-            "swim/member": "\(change.member.node)",
-            "swim/member/previousStatus": "\(change.previousStatus.map({"\($0)"}) ?? "unknown")",
-            "swim/member/status": "\(change.status)",
-        ])
+        self.log.info(
+            "Membership status changed: [\(change.member.node)] is now [\(change.status)]",
+            metadata: [
+                "swim/member": "\(change.member.node)",
+                "swim/member/previousStatus": "\(change.previousStatus.map({"\($0)"}) ?? "unknown")",
+                "swim/member/status": "\(change.status)",
+            ]
+        )
     }
 }

Samples/Sources/SWIMNIOSampleCluster/SWIMNIOSampleNode.swift

@@ -12,23 +12,23 @@
 //
 //===----------------------------------------------------------------------===//
 
+import ArgumentParser
 import ClusterMembership
-import SWIM
+import Lifecycle
+import Logging
 import Metrics
+import NIO
 import Prometheus
+import SWIM
 import SWIMNIOExample
-import NIO
-import Logging
-import Lifecycle
-import ArgumentParser
 
 struct SWIMNIOSampleCluster: ParsableCommand {
     @Option(name: .shortAndLong, help: "The number of nodes to start, defaults to: 1")
     var count: Int?
 
     @Argument(help: "Hostname that node(s) should bind to")
     var host: String?
-    
+
     @Option(help: "Determines which this node should bind to; Only effective when running a single node")
     var port: Int?
 
@@ -47,17 +47,17 @@ struct SWIMNIOSampleCluster: ParsableCommand {
         //
         // Note though that this will be a bit noisy, since logs are also emitted to the stdout by default, however it's a nice way
         // to learn and explore what the metrics are and how they behave when toying around with a local cluster.
-//        let prom = PrometheusClient()
-//        MetricsSystem.bootstrap(prom)
-//
-//        group.next().scheduleRepeatedTask(initialDelay: .seconds(1), delay: .seconds(10)) { _ in
-//             prom.collect { (string: String) in
-//                 print("")
-//                 print("")
-//                 print(string)
-//             }
-//        }
-        
+        //        let prom = PrometheusClient()
+        //        MetricsSystem.bootstrap(prom)
+        //
+        //        group.next().scheduleRepeatedTask(initialDelay: .seconds(1), delay: .seconds(10)) { _ in
+        //             prom.collect { (string: String) in
+        //                 print("")
+        //                 print("")
+        //                 print(string)
+        //             }
+        //        }
+
         let lifecycle = ServiceLifecycle()
         lifecycle.registerShutdown(
             label: "eventLoopGroup",
@@ -101,7 +101,7 @@ struct SWIMNIOSampleCluster: ParsableCommand {
                 )
             }
         }
-        
+
         try lifecycle.startAndWait()
     }
 
@@ -116,7 +116,7 @@ struct SWIMNIOSampleCluster: ParsableCommand {
         guard self.initialContactPoints.trimmingCharacters(in: .whitespacesAndNewlines) != "" else {
             return []
         }
-        
+
         let contactPoints: [Node] = self.initialContactPoints.split(separator: ",").map { hostPort in
             let host = String(hostPort.split(separator: ":")[0])
             let port = Int(String(hostPort.split(separator: ":")[1]))!

Samples/Sources/SWIMNIOSampleCluster/main.swift

@@ -25,7 +25,7 @@ import XCTest
 
 XCTMain(
     [
-        testCase(SampleTest.allTests),
+        testCase(SampleTest.allTests)
     ]
 )
 #endif

Samples/Tests/LinuxMain.swift

@@ -38,19 +38,24 @@ extension SWIM {
         /// Create new event, representing a change of the member's status from a previous state to its current state.
         public init(previousStatus: SWIM.Status?, member: SWIM.Member<Peer>) {
             if let from = previousStatus, from == .dead {
-                precondition(member.status == .dead, "Change MUST NOT move status 'backwards' from [.dead] state to anything else, but did so, was: \(member)")
+                precondition(
+                    member.status == .dead,
+                    "Change MUST NOT move status 'backwards' from [.dead] state to anything else, but did so, was: \(member)"
+                )
             }
 
             self.previousStatus = previousStatus
             self.member = member
 
             switch (self.previousStatus, member.status) {
             case (.dead, .alive),
-                 (.dead, .suspect),
-                 (.dead, .unreachable):
-                fatalError("SWIM.Membership MUST NOT move status 'backwards' from .dead state to anything else, but did so, was: \(self)")
+                (.dead, .suspect),
+                (.dead, .unreachable):
+                fatalError(
+                    "SWIM.Membership MUST NOT move status 'backwards' from .dead state to anything else, but did so, was: \(self)"
+                )
             default:
-                () // ok, all other transitions are valid.
+                ()  // ok, all other transitions are valid.
             }
         }
     }
@@ -73,13 +78,13 @@ extension SWIM.MemberStatusChangedEvent {
         // alive and suspect does NOT affect high-level reachability).
         switch (fromStatus, self.status) {
         case (.alive, .unreachable),
-             (.alive, .dead):
+            (.alive, .dead):
             return true
         case (.suspect, .unreachable),
-             (.suspect, .dead):
+            (.suspect, .dead):
             return true
         case (.unreachable, .alive),
-             (.unreachable, .suspect):
+            (.unreachable, .suspect):
             return true
         default:
             return false

Sources/SWIM/Events.swift

@@ -13,6 +13,7 @@
 //===----------------------------------------------------------------------===//
 
 import ClusterMembership
+
 @preconcurrency import struct Dispatch.DispatchTime
 
 // ==== ----------------------------------------------------------------------------------------------------------------
@@ -43,7 +44,7 @@ extension SWIM {
         ///
         /// - Note: Only suspect members may have this value set, but having the actual field in SWIM.Member feels more natural.
         /// - Note: This value is never carried across processes, as it serves only locally triggering suspicion timeouts.
-        public let localSuspicionStartedAt: DispatchTime? // could be "status updated at"?
+        public let localSuspicionStartedAt: DispatchTime?  // could be "status updated at"?
 
         /// Create a new member.
         public init(peer: Peer, status: SWIM.Status, protocolPeriod: UInt64, suspicionStartedAt: DispatchTime? = nil) {
@@ -86,9 +87,7 @@ extension SWIM {
 /// Manual Hashable conformance since we omit `suspicionStartedAt` from identity
 extension SWIM.Member: Hashable, Equatable {
     public static func == (lhs: SWIM.Member<Peer>, rhs: SWIM.Member<Peer>) -> Bool {
-        lhs.peer.node == rhs.peer.node &&
-            lhs.protocolPeriod == rhs.protocolPeriod &&
-            lhs.status == rhs.status
+        lhs.peer.node == rhs.peer.node && lhs.protocolPeriod == rhs.protocolPeriod && lhs.status == rhs.status
     }
 
     public func hash(into hasher: inout Hasher) {

Sources/SWIM/Member.swift

@@ -110,26 +110,26 @@ extension SWIM {
                 self.messageInboundCount = Counter(
                     label: settings.metrics.makeLabel("message", "count"),
                     dimensions: [
-                        ("direction", "in"),
+                        ("direction", "in")
                     ]
                 )
                 self.messageInboundBytes = Recorder(
                     label: settings.metrics.makeLabel("message", "bytes"),
                     dimensions: [
-                        ("direction", "in"),
+                        ("direction", "in")
                     ]
                 )
 
                 self.messageOutboundCount = Counter(
                     label: settings.metrics.makeLabel("message", "count"),
                     dimensions: [
-                        ("direction", "out"),
+                        ("direction", "out")
                     ]
                 )
                 self.messageOutboundBytes = Recorder(
                     label: settings.metrics.makeLabel("message", "bytes"),
                     dimensions: [
-                        ("direction", "out"),
+                        ("direction", "out")
                     ]
                 )
             }
@@ -200,7 +200,7 @@ extension SWIM.Metrics {
             case .unreachable:
                 unreachables += 1
             case .dead:
-                () // dead is reported as a removal when they're removed and tombstoned, not as a gauge
+                ()  // dead is reported as a removal when they're removed and tombstoned, not as a gauge
             }
         }
         self.membersAlive.record(alives)