added preliminary Python 3 support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 2 EOL is close, is it possible to include this PR and release a new version on PyPI? @EliAndrewC seems like you are the main author and the project seems inactive, did you consider taking over 🙏? |
|
I'd like to add my +1 here. @EliAndrewC could you please merge this PR and cut a new release on PyPI? You seem to be the only maintainer there as well. I'm happy to fork and assume maintenance of this package, if you're not interested in it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All unit tests now pass on both Python 2 and Python 3.
However, since I no longer work at Applied Security and don't use collectd at my current job, I can't conveniently test this on a live system. So I'll kick this over to those folks to review and accept it.