Remove ember-composable-helpers

We don't really need it, and the few couple of helpers we use can be easily implemented as a private helper where needed.

Author: Windvis

addon/components/au-data-table.hbs

@@ -22,7 +22,7 @@
           noDataMessage=this.noDataMessage
           enableSelection=this.enableSelection
           enableLineNumbers=this.enableLineNumbers
-          onClickRow=(optional this.onClickRow)
+          onClickRow=this.onClickRow
           data-table=this
         )
       )
@@ -42,7 +42,7 @@
       @noDataMessage={{this.noDataMessage}}
       @enableSelection={{this.enableSelection}}
       @enableLineNumbers={{this.enableLineNumbers}}
-      @onClickRow={{optional this.onClickRow}}
+      @onClickRow={{this.onClickRow}}
       @data-table={{this}}
     />
   {{/if}}

addon/components/au-data-table/content-body.hbs

@@ -5,10 +5,10 @@
     {{#each this.wrappedItems as |wrapper index|}}
       <tr
         class={{if
-          (includes wrapper.item this.data-table.selection)
+          (this.includes this.data-table.selection wrapper.item)
           "selected"
         }}
-        {{on "click" (fn (optional this.onClickRow) wrapper.item)}}
+        {{on "click" (fn (this.optional this.onClickRow) wrapper.item)}}
         {{!template-lint-disable no-invalid-interactive}}
       >
         {{#if this.enableSelection}}

addon/components/au-data-table/content-body.js

@@ -4,7 +4,7 @@ import { action, computed } from '@ember/object';
 import Component from '@ember/component';
 
 // Source: https://github.com/mu-semtech/ember-data-table/blob/c690a3948b2d9d5f91d69f0a935c6b5cdb4862ca/addon/components/data-table-content-body.js
-export default Component.extend({
+const ContentBody = Component.extend({
   tagName: 'tbody',
   init() {
     this._super(...arguments);
@@ -42,7 +42,16 @@ export default Component.extend({
       }
     });
   }),
+});
+
+export default ContentBody.extend({
   add(a, b) {
     return a + b;
-  }
+  },
+  includes(array, item) {
+    return array.includes(item);
+  },
+  optional(maybeFunction) {
+    return typeof maybeFunction === 'function' ? maybeFunction : () => {};
+  },
 });

addon/components/au-data-table/content.hbs

@@ -16,7 +16,7 @@
             enableSelection=this.enableSelection
             enableLineNumbers=this.enableLineNumbers
             noDataMessage=this.noDataMessage
-            onClickRow=(optional this.onClickRow)
+            onClickRow=this.onClickRow
             data-table=this.data-table
           )
         )
@@ -32,7 +32,7 @@
         @enableSelection={{this.enableSelection}}
         @enableLineNumbers={{this.enableLineNumbers}}
         @noDataMessage={{this.noDataMessage}}
-        @onClickRow={{optional this.onClickRow}}
+        @onClickRow={{this.onClickRow}}
         @data-table={{this.data-table}}
       />
     {{/if}}

addon/components/au-data-table/menu-selected.hbs

@@ -1,6 +1,3 @@
 {{#unless this.data-table.selectionIsEmpty}}
-  {{yield
-    (slice 0 this.selectionCount this.data-table.selection)
-    this.data-table
-  }}
+  {{yield this.selection this.data-table}}
 {{/unless}}

addon/components/au-data-table/menu-selected.js

@@ -1,10 +1,10 @@
 /* eslint-disable ember/no-classic-classes, ember/no-classic-components, ember/no-get, ember/require-tagless-components */
-import { action } from '@ember/object';
+import { action, computed } from '@ember/object';
 import { reads } from '@ember/object/computed';
 import Component from '@ember/component';
 
 // Source: https://github.com/mu-semtech/ember-data-table/blob/c690a3948b2d9d5f91d69f0a935c6b5cdb4862ca/addon/components/data-table-menu-selected.js
-export default Component.extend({
+const MenuSelected = Component.extend({
   init: function () {
     this._super(...arguments);
     this.set('data-table.enableSelection', true);
@@ -14,3 +14,9 @@ export default Component.extend({
     this.get('data-table').clearSelection();
   }),
 });
+
+export default MenuSelected.extend({
+  selection: computed('data-table.selection.[]', function () {
+    return this.get('data-table.selection').slice();
+  }),
+});