some improvements

- set `mergeAmbiguousCharacters` to true since some of the icons contain numbers in the name: circle-step-1 > CircleStep_1Icon vs CircleStep1Icon
- rename some variables
- shorten some code

Author: Windvis

lib/generate-icon-components.mjs

@@ -28,24 +28,25 @@ const promises = icons.map((svg) => {
 await Promise.all(promises);
 
 async function generateComponent(iconName) {
-  const componentName = pascalCase(iconName);
+  const componentName = pascalCase(iconName, { mergeAmbiguousCharacters: true });
 
-  const iconContent = await readFile(join(ICON_FOLDER, iconName + ".svg"));
-  const iconContentWithAttributes = iconContent
+  const iconContent = (await readFile(join(ICON_FOLDER, iconName + ".svg")))
     .toString()
-    .replace(">", " ...attributes>"); // We assume the first closing element is the svg element
+    .replace(">", " ...attributes>"); // We assume the first closing bracket belongs to the svg element
 
-  const component = `// THIS FILE IS GENERATED. ANY CHANGES TO THIS FILE WILL BE LOST.
+  const componentContent = `// THIS FILE IS GENERATED. ANY CHANGES TO THIS FILE WILL BE LOST.
 import type { TOC } from '@ember/component/template-only';
 
 export interface ${componentName}IconSignature {
-  Element: SVGElement;
+  Element: SVGSVGElement;
 }
 
-export const ${componentName}Icon: TOC<${componentName}IconSignature> = <template>${iconContentWithAttributes}</template>;
-export default ${componentName}Icon;`;
+export const ${componentName}Icon: TOC<${componentName}IconSignature> = <template>${iconContent}</template>;`;
 
-  await writeFile(join(COMPONENT_ICON_FOLDER, iconName + ".gts"), component);
+  await writeFile(
+    join(COMPONENT_ICON_FOLDER, iconName + ".gts"),
+    componentContent,
+  );
 }
 
 async function prepareOutputDir() {