Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The <AuModal> @size and @overflow arguments don't work together #477

Closed
Windvis opened this issue Mar 11, 2024 · 0 comments · Fixed by #479
Closed

The <AuModal> @size and @overflow arguments don't work together #477

Windvis opened this issue Mar 11, 2024 · 0 comments · Fixed by #479
Labels
bug Used when the PR fixes a bug included in a previous release.

Comments

@Windvis
Copy link
Contributor

Windvis commented Mar 11, 2024

While trying out #476 I noticed that the @size argument doesn't work as expected when @overflow is set, due to missing whitespace between the classes. The issue has been around for a while, so I'm guessing these options aren't used that much 😅.

Reproduction in the current Storybook deploy: https://appuniversum.github.io/ember-appuniversum/?path=/story/components-content-aumodal--component&args=size:large;overflow:true (should show the large version, but it doesn't)

@Windvis Windvis added the bug Used when the PR fixes a bug included in a previous release. label Mar 11, 2024
@Windvis Windvis changed the title <AuModal> @size and @overflow don't work together The <AuModal> @size and @overflow arguments don't work together Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used when the PR fixes a bug included in a previous release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant