-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of floating UI helpers #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍!
For now I think it would be better to keep this functionality "private", so only available for internal use in Appuniversum. If we want to use the functionality in apps as well I think a dedicated generic floating-ui addon would be better suited.
If we go for the private variant I think it makes sense to create an addon/private
folder where we can store things. Since we now support only 3.28+ we can remove the app reexports and simply import the private component / modifier where needed without it being available in the "global" template scope.
(Also, FYI, I don't think Dieter is working on Appuniversum anymore) |
Thanks!
Sure thing! Regarding Storybook, I would rather like to keep that story so that Chromatic can run visual tests on it. What would be the best way to go (knowing the component is for internal usage only): keep the story visible in the sidebar but under something like 'internal usage only' or hide the story using a CSS solution mentioned here: storybookjs/storybook#9209 (an internal solution to hide stories in the sidebar is not implemented yet sadly). What do you think? |
Oh, did not know that 😕 Thanks for giving me a heads-up . |
Also, since the component version has a bug, it probably makes sense to not include it for now? I would push a new branch with the current state and remove the component version + docs from this one. That way we can pick it back up when the issue is resolved? |
Done! Those changes will be available inside the |
@Windvis I think this one is good to go 🤞 Feel free to give the final ok. (I'll finalise the integration of the floating-ui helper within the dropdown component when this is done) |
The addition of a floating UI modifier & component for further use within other components that use popovers, dropdowns, etc.
The modifier & component are created with the use of https://floating-ui.com/.
This component (& modifier in a more limited way) can:
auto
,scroll
, etc.) by utilising afixed
positionWhat still must be done is:
See #333 for additional information.