Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying multiple modals at the same time #476

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add support for displaying multiple modals at the same time #476

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
992ca26
add insertBefore=null so the content of the existing modal isn't repl…
Mar 11, 2024
1352ab2
add test showing two modals at once
Mar 12, 2024
4046458
add deprecation warning for modal backdrop z index variable
Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/au-modal.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class AuModal extends Component {

<template>
{{#if @modalOpen}}
{{#in-element this.destinationElement}}
{{#in-element this.destinationElement insertBefore=null}}
<div class="au-c-modal-backdrop {{if @modalOpen 'is-visible'}}"></div>
<div
id="{{@id}}"
Expand Down
2 changes: 1 addition & 1 deletion styles/components/_c-modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
========================================================================== */

$au-modal-z-index: 9999 !default;
$au-modal-backdrop-z-index: 9998 !default;
$au-modal-backdrop-z-index: 9999 !default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Does it still make sense to make this configurable after this change? For this to work properly both z-index values need to be the same I think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed it should be the same. I wanted to keep it around in case others would use this property, but if you prefer i can remove it instead?


/* Component
========================================================================== */
Expand Down
Loading