Skip to content

Commit 06e73a3

Browse files
authored
[HELM] fix the registerCRDs parameter (#1612)
When setting the parameter to false, the CRDs are still being registered and controller fails to start as it is not able to read the CRDs. Signed-off-by: Roland Kool <rkool@bol.com>
1 parent 15370e9 commit 06e73a3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

charts/terranetes-controller/templates/deployment.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ spec:
9696
- --tls-key={{ .Values.controller.webhooks.tlsKey }}
9797
- --webhooks-port={{ .Values.controller.webhooks.port }}
9898
{{- end }}
99+
- --register-crds={{ .Values.controller.registerCRDs }}
99100
{{- range $key, $value := .Values.controller.extraArgs }}
100101
- --{{ $key }}={{ $value }}
101102
{{- end }}

charts/terranetes-controller/templates/rbac.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ kind: ClusterRole
2121
metadata:
2222
name: {{ include "terranetes-controller.fullname" . }}
2323
rules:
24-
{{- if .Values.controller.registerCRDs }}
2524
- apiGroups:
2625
- apiextensions.k8s.io
2726
resources:
2827
- customresourcedefinitions
2928
verbs:
30-
- create
3129
- get
3230
- list
31+
{{- if .Values.controller.registerCRDs }}
32+
- create
3333
- patch
3434
- update
3535
{{- end }}

0 commit comments

Comments
 (0)