fix: probe bpf func #475
Merged
fix: probe bpf func #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rscampos
commented
Jan 16, 2025
•
rscampos
commented
- Improved BPFHelperIsSupported by enhancing error reporting to include detailed messages for unsupported helpers and unexpected errno values returned by libbpf;
- Added logic to handle unexpected errno states and clarified support assumptions based on retC == 1 when running with capabilities.
|
As we discussed offline, it's better to return to origins and make the libbpfgo, mostly for this matter, return ret and errno as it is. Please provide comments about the findings related to libbpf and kernel. Tks! |
rscampos
force-pushed
the
fix_prob_bpf_helper
branch
4 times, most recently
from
25ec2fb to
ff87197
Compare
- Improved BPFHelperIsSupported by enhancing error reporting to include detailed messages for unsupported helpers and unexpected errno values returned by libbpf; - Added logic to handle unexpected errno states and clarified support assumptions based on retC == 1 when running with capabilities.
- align the err msg return; - remove one test case - the func helper is enabled for the type for new kernels.
rscampos
force-pushed
the
fix_prob_bpf_helper
branch
from
ff87197 to
9aead27
Compare
geyslan
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.