Add ringbuf support tests #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selftest ecosystem was not designed to run on different kernels (e.g.: using virtme-ng), but it is feasible to do it with some caveats.
rscampos
reviewed
Feb 12, 2025
rscampos
reviewed
Feb 12, 2025
rscampos
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM...
The tool virtme-ng is very cool, good use case for us.
On AWS, it took around 10 min to download a precompiled upstream kernel, but locally it was fast. As we discussed, maybe would be good (when we heavily use virtme-ng), to have an image with some kernels already cached.
good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.