Gasless propose execution multisig on settings #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
changed the title
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
2 times, most recently
from
c76dea5 to
c49c97f
Compare
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
4 times, most recently
from
129dfa5 to
c0eddef
Compare
selankon
force-pushed
the
f/gasless-voting-bugfixes-2
branch
from
f4ba7fb to
b3dfa00
Compare
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
from
c0eddef to
1c6b814
Compare
selankon
force-pushed
the
f/gasless-voting-bugfixes-2
branch
from
b99e889 to
55d8a81
Compare
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
from
957997b to
b79ed07
Compare
selankon
force-pushed
the
f/gasless-voting-bugfixes-2
branch
from
55d8a81 to
2246eaa
Compare
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
from
b79ed07 to
3d363c0
Compare
jamesej
suggested changes
Feb 2, 2024
selankon
force-pushed
the
f/gasless-voting-bugfixes-2
branch
from
37d5918 to
fccccd8
Compare
I have problems integrating the components under `src/containers/manageExecutionMultisig/index.tsx` into the form. For some reason, the `AddAddresses` component causes that the context form `isDirty` to be false at some point, opening the "isDirty" loader and provoking a rerender of the page. When the isDirty is again true, and the page renders the form, it opens the `AccordionMultiple` default value, creating an effect of "open/close" for the gasless settings accordion item. For the moment, I deleted this loader to continue developing this branch meanwhile I talk with @Fabricevladimir to try to find a better solution.
It implements multiple fixes to adapt the form validation to the actual component behavior: - A custom validator for the add address to let the first row to be empty (for ux purposes) - Use the actions validator used on the manage members form - Implement a function to check if the add/remove actions are added. Now, the form should work properly, adding a "new settings" label and disabling the button when needed.
Accurs when go back from review proposal screeb, the empty actions are deleted so they can be undefined.
Avoid flickering Related to 89bca30
When going back and forward or modifying the settings
Not needed anymore, the executive committee members are going to be modified using the edit settings form
selankon
force-pushed
the
f/gasless-propose-em-on-settings
branch
from
962b495 to
6431b4a
Compare
|
WebApp IPFS Hash: QmSaWU9Frmph4VbbR1VKpipeKnw98hqPUDG5ipeg64Cv9S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: APP-0000
Type of change
Checklist:
CHANGELOG.mdfile in the root folder.