Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-2557- Fix: Cached DAO type after creation #1189

Merged
merged 1 commit into from
Jan 10, 2024
Merged

APP-2557- Fix: Cached DAO type after creation #1189

merged 1 commit into from
Jan 10, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Jan 8, 2024 •
edited by jira bot
Loading

Description

  • Set installed plugin typed as id after dao creation

Task: APP-2557

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@sepehr2github sepehr2github requested a review from a team January 8, 2024 12:29
cgero-eth
cgero-eth approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sepehr2github ✅

@sepehr2github sepehr2github merged commit f013a48 into develop Jan 10, 2024
2 of 3 checks passed
@sepehr2github sepehr2github deleted the fix/created-dao-list branch January 10, 2024 11:08
ghost pushed a commit to PluralityCN-Research-Group/Aragon_App that referenced this pull request Jan 13, 2024
@sepehr2github
fix cached DAO type after creation (aragon#1189)
dda117c
ghost pushed a commit to PluralityCN-Research-Group/Aragon_App that referenced this pull request Jan 13, 2024
@sepehr2github
fix cached DAO type after creation (aragon#1189)
5e4c408
selankon pushed a commit that referenced this pull request Jan 26, 2024
@sepehr2github @selankon
fix cached DAO type after creation (#1189)
2f760bf
ghost pushed a commit to PluralityCN-Research-Group/Aragon_App that referenced this pull request Feb 11, 2024
@sepehr2github
fix cached DAO type after creation (aragon#1189)
b8a8aa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepehr2github @cgero-eth