Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-2697 - When +3 Links at Dashboard they display on Links Drop down and Dashboard #1190

Closed
wants to merge 1 commit into from

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jan 9, 2024

Description

When number of links is greater than DEFAULT_LINKS_SHOWN (3) than it would still display the LinksWrapper at Desktop. With the edits in this PR the LinksWrapper only displays when the total number of links equals or is smaller than DEFAULT_LINKS_SHOWN.

See images below for before and after edits.

Note: the image displaying in front of the drop down is taken care of in another ticket.

Before
image

After
image

Task: APP-2697

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Barukimang Barukimang requested a review from cgero-eth January 9, 2024 10:15
@Barukimang
Copy link
Collaborator Author

Barukimang commented Jan 9, 2024

Closing this PR, see more details here @RuggeroCino

@Barukimang Barukimang closed this Jan 9, 2024
@cgero-eth cgero-eth deleted the fix/2697-duplicate-links branch August 8, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant