-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gasless fix proposal dates #1199
Conversation
1d5b311
to
e26ae52
Compare
b5fa766
to
6cf7a5a
Compare
55d8a81
to
2246eaa
Compare
6cf7a5a
to
6f3497d
Compare
37d5918
to
fccccd8
Compare
1dbda24
to
8d59e4e
Compare
8d59e4e
to
8df175f
Compare
(but not throw in develop :-| ) Signed-off-by: emmdim <emmdim@users.noreply.github.com>
Gasless elections and onchain elections had different end dates. Now they have the same
8df175f
to
f56fe1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hitting a white screen as soon as I try to create a proposal with a Vocdoni DAO. Top level error is on createProposal.tsx:154
because votingSettings
is null. The source of this error is usePluginClient
returning null. Line 83 appears odd and is showing a type error in VSCode with the second context
parameter.
This apparently refers to an older version of the branched to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hit a gas fee estimation error, Manos kindly worked out it was
Error Message: InvalidVoteEndDate[1707330495,1707330180]
revert InvalidVoteEndDate({limit: earliestVoteEndDate, actual: voteEndDate});
He's pinged @Ritmo in the chat about this.
113b93c
to
bdbc1b5
Compare
WebApp IPFS Hash: Qmcw8Kva53peAdKK7d4rHXE6mN8Vyc6kBLK8gZs1v8DfS1 |
@jamesej can you please re-test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now thanks!
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: APP-0000
Type of change
Checklist:
CHANGELOG.md
file in the root folder.