Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gasless fix proposal dates #1199

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Gasless fix proposal dates #1199

merged 7 commits into from
Feb 12, 2024

Conversation

selankon
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: APP-0000

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 1d5b311 to e26ae52 Compare January 19, 2024 10:21
@selankon selankon changed the base branch from develop to f/gasless-voting-bugfixes-2 January 26, 2024 08:12
@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from b5fa766 to 6cf7a5a Compare January 26, 2024 08:20
@selankon selankon marked this pull request as ready for review January 26, 2024 08:20
@selankon selankon force-pushed the f/gasless-voting-bugfixes-2 branch from 55d8a81 to 2246eaa Compare January 26, 2024 12:37
@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 6cf7a5a to 6f3497d Compare January 26, 2024 12:45
@selankon selankon force-pushed the f/gasless-voting-bugfixes-2 branch from 37d5918 to fccccd8 Compare February 5, 2024 11:22
Base automatically changed from f/gasless-voting-bugfixes-2 to develop February 7, 2024 11:50
@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 1dbda24 to 8d59e4e Compare February 7, 2024 12:10
@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 8d59e4e to 8df175f Compare February 7, 2024 12:17
emmdim and others added 6 commits February 7, 2024 13:46
(but not throw in develop :-| )

Signed-off-by: emmdim <emmdim@users.noreply.github.com>
Gasless elections and onchain elections had different end dates. Now they have the same
@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 8df175f to f56fe1f Compare February 7, 2024 12:47
Copy link
Contributor

@jamesej jamesej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hitting a white screen as soon as I try to create a proposal with a Vocdoni DAO. Top level error is on createProposal.tsx:154 because votingSettings is null. The source of this error is usePluginClient returning null. Line 83 appears odd and is showing a type error in VSCode with the second context parameter.

@emmdim emmdim requested a review from jamesej February 7, 2024 15:49
@emmdim
Copy link
Contributor

emmdim commented Feb 7, 2024

I'm hitting a white screen as soon as I try to create a proposal with a Vocdoni DAO. Top level error is on createProposal.tsx:154 because votingSettings is null. The source of this error is usePluginClient returning null. Line 83 appears odd and is showing a type error in VSCode with the second context parameter.

This apparently refers to an older version of the branched to be reviewed

Copy link
Contributor

@jamesej jamesej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit a gas fee estimation error, Manos kindly worked out it was

Error Message: InvalidVoteEndDate[1707330495,1707330180]
revert InvalidVoteEndDate({limit: earliestVoteEndDate, actual: voteEndDate});

He's pinged @Ritmo in the chat about this.

@selankon selankon force-pushed the f/gasless-fix-proposal-dates branch from 113b93c to bdbc1b5 Compare February 8, 2024 14:35
Copy link

github-actions bot commented Feb 8, 2024

WebApp IPFS Hash: Qmcw8Kva53peAdKK7d4rHXE6mN8Vyc6kBLK8gZs1v8DfS1
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/Qmcw8Kva53peAdKK7d4rHXE6mN8Vyc6kBLK8gZs1v8DfS1/

@emmdim emmdim requested a review from jamesej February 9, 2024 10:27
@emmdim
Copy link
Contributor

emmdim commented Feb 9, 2024

@jamesej can you please re-test?

Copy link
Contributor

@jamesej jamesej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now thanks!

@emmdim emmdim merged commit c8d55c9 into develop Feb 12, 2024
4 of 5 checks passed
@emmdim emmdim deleted the f/gasless-fix-proposal-dates branch February 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants