Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2699 - Use Aragon Gateway for RPC requests #1200

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: APP-2699 - Use Aragon Gateway for RPC requests #1200

merged 4 commits into from
Jan 23, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jan 18, 2024 •
edited
Loading

Description

  • Update providers handling to use new Aragon Gateway for RPC requests
  • Rename VITE_INFURA_MAINNET_PROJECT_ID to VITE_GATEWAY_RPC_API_KEY

Task: APP-2699

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@cgero-eth cgero-eth force-pushed the feat-APP-2699-use-gateway-rpc branch from 8b7ed45 to 8d983f6 Compare January 18, 2024 13:45
@cgero-eth cgero-eth changed the title WIP: feat: APP-2699 - Use Aragon Gateway for RPC requests feat: APP-2699 - Use Aragon Gateway for RPC requests Jan 19, 2024
@cgero-eth cgero-eth requested review from chilcano and a team January 19, 2024 09:38
@cgero-eth cgero-eth marked this pull request as ready for review January 19, 2024 09:38
Fabricevladimir
Fabricevladimir approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, hopefully we caught everything 😅

src/hooks/useWallet.tsx
});
} else return signer?.provider;
}, [network, signer?.provider]);
const provider = useMemo(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepehr2github Do you know why we are bypassing the signer provider on Polygon and Mumbai?

@cgero-eth cgero-eth force-pushed the feat-APP-2699-use-gateway-rpc branch from 1322dcf to ea2bf80 Compare January 23, 2024 08:59
@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: QmRcGW7c6W1Vd7gdsbuFVBPT1DpqPpKU6GQRz2SidBXC9G
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmRcGW7c6W1Vd7gdsbuFVBPT1DpqPpKU6GQRz2SidBXC9G/

@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: QmZ5GkhiB4T5cXfT167Scmc2tb8hTUXC2aAeVqEWcbVsnR
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmZ5GkhiB4T5cXfT167Scmc2tb8hTUXC2aAeVqEWcbVsnR/

@cgero-eth cgero-eth merged commit ecb7c5f into develop Jan 23, 2024
4 of 5 checks passed
@cgero-eth cgero-eth deleted the feat-APP-2699-use-gateway-rpc branch January 23, 2024 09:19
jamesej added a commit that referenced this pull request Feb 5, 2024
@jamesej
Revert "feat: APP-2699 - Use Aragon Gateway for RPC requests (#1200)"
03b6ba5 
This reverts commit ecb7c5f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

@chilcano chilcano Awaiting requested review from chilcano

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir