Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TokenBalances Covalent route to backend #1211

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Move TokenBalances Covalent route to backend #1211

merged 6 commits into from
Feb 1, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Jan 30, 2024 •
edited
Loading

Description

  • Replaced Covalent API with backend one for total token fetching

Task: APP-2828

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@sepehr2github sepehr2github marked this pull request as ready for review February 1, 2024 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

WebApp IPFS Hash: QmcR1LjSehU1Qbdzu7KKBn8qfravw9a6vf64Ut6wiqXhLW
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmcR1LjSehU1Qbdzu7KKBn8qfravw9a6vf64Ut6wiqXhLW/

@sepehr2github sepehr2github merged commit 236fc32 into develop Feb 1, 2024
4 of 5 checks passed
@sepehr2github sepehr2github deleted the fix/TokenBalanceCovalent branch February 1, 2024 11:25
Fabricevladimir
Fabricevladimir reviewed Feb 1, 2024
View reviewed changes
src/services/token/domain/covalent-token.ts
contract_ticker_symbol: string;
contract_address: string;
logo_url: string;
export type TokenItemType = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this solely a Covalent token or does this also include the response for a Coingecko call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir left review comments

@Barukimang Barukimang Barukimang approved these changes

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sepehr2github @Barukimang @Fabricevladimir