Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-3157 & APP-3176 - Fixes for Members page view with Vocdoni DAOs #1345

Merged
merged 1 commit into from
May 17, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented May 10, 2024

Description

Handle table formatting of members view for Vocdoni DAOs by passing down a Vocdoni boolean prop to handle the exception where "delegation is enabled" logic creates an OBOE with the cells per row. All fixes issue with 0 members from Census3 subgraph showing 0 members initially in the page header.

Task: APP-3157
Task: APP-3176

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

WebApp IPFS Hash: QmQHdipW149FdLDMtNjhshVegYwF8sHKoSnuDxXGUgsh13
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmQHdipW149FdLDMtNjhshVegYwF8sHKoSnuDxXGUgsh13/

Copy link
Contributor

@sepehr2github sepehr2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thekidnamedkd. It Works!

@thekidnamedkd thekidnamedkd merged commit 4d26ad3 into develop May 17, 2024
3 checks passed
@thekidnamedkd thekidnamedkd deleted the fix/APP-3157 branch May 17, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants