Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APP-3157 & APP-3156 - Fix Vocdoni DAO Member view issues #1350

Merged
merged 4 commits into from
May 22, 2024
Merged

fix: APP-3157 & APP-3156 - Fix Vocdoni DAO Member view issues #1350

merged 4 commits into from
May 22, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented May 20, 2024 •
edited by jira bot
Loading

Description

Resolve QA highlights for Vocdoni DAO members issues

Task: APP-3157
Task: APP-3176

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: Qmc4zmaKUQ8pwKz4FnLfj7umkJAV9zWeB3aHbPcqEfQLVh
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/Qmc4zmaKUQ8pwKz4FnLfj7umkJAV9zWeB3aHbPcqEfQLVh/

@thekidnamedkd thekidnamedkd requested review from a team and sepehr2github May 21, 2024 07:03
sepehr2github
sepehr2github approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@sepehr2github sepehr2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed a test, It works, Thanks Kevin

@thekidnamedkd thekidnamedkd merged commit a91299a into develop May 22, 2024
3 checks passed
@thekidnamedkd thekidnamedkd deleted the fix/APP-3175 branch May 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepehr2github sepehr2github sepehr2github approved these changes

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @sepehr2github