Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3298): Add support for ZkSync mainnet #1376

Merged
merged 6 commits into from
Jun 27, 2024
Merged

feat(APP-3298): Add support for ZkSync mainnet #1376

merged 6 commits into from
Jun 27, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Jun 25, 2024 •
edited by jira bot
Loading

Description

  • ZkSync support added

Task: APP-3289

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@sepehr2github sepehr2github marked this pull request as ready for review June 26, 2024 11:43
@sepehr2github sepehr2github requested a review from a team June 26, 2024 11:43
cgero-eth
cgero-eth reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @sepehr2github! I only left a question on the PR

@sepehr2github sepehr2github requested a review from cgero-eth June 26, 2024 21:41
cgero-eth
cgero-eth approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sepehr2github!

@cgero-eth cgero-eth merged commit 8871e96 into develop Jun 27, 2024
3 checks passed
@cgero-eth cgero-eth deleted the f/app-3289 branch June 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepehr2github @cgero-eth