Skip to content

Commit 008947e

Browse files
committed
Fixes post-review
1 parent c30a767 commit 008947e

File tree

2 files changed

+17
-23
lines changed

2 files changed

+17
-23
lines changed

arango/request.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ class Request:
6262
:type exclusive: str | [str] | None
6363
:param deserialize: Whether the response body can be deserialized.
6464
:type deserialize: bool
65-
:param driverFlags: List of flags for the driver
66-
:type driverFlags: list
65+
:param driver_flags: List of flags for the driver
66+
:type driver_flags: list
6767
6868
:ivar method: HTTP method in lowercase (e.g. "post").
6969
:vartype method: str
@@ -85,8 +85,8 @@ class Request:
8585
:vartype exclusive: str | [str] | None
8686
:ivar deserialize: Whether the response body can be deserialized.
8787
:vartype deserialize: bool
88-
:ivar driverFlags: List of flags for the driver
89-
:vartype driverFlags: list
88+
:ivar driver_flags: List of flags for the driver
89+
:vartype driver_flags: list
9090
"""
9191

9292
__slots__ = (
@@ -99,7 +99,7 @@ class Request:
9999
"write",
100100
"exclusive",
101101
"deserialize",
102-
"driverFlags",
102+
"driver_flags",
103103
)
104104

105105
def __init__(
@@ -113,15 +113,15 @@ def __init__(
113113
write: Optional[Fields] = None,
114114
exclusive: Optional[Fields] = None,
115115
deserialize: bool = True,
116-
driverFlags: Optional[DriverFlags] = None,
116+
driver_flags: Optional[DriverFlags] = None,
117117
) -> None:
118118
self.method = method
119119
self.endpoint = endpoint
120-
self.headers: Headers = normalize_headers(headers, driverFlags)
120+
self.headers: Headers = normalize_headers(headers, driver_flags)
121121
self.params: MutableMapping[str, str] = normalize_params(params)
122122
self.data = data
123123
self.read = read
124124
self.write = write
125125
self.exclusive = exclusive
126126
self.deserialize = deserialize
127-
self.driverFlags = driverFlags
127+
self.driver_flags = driver_flags

tests/test_request.py

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ def test_request_no_data() -> None:
1111
assert request.method == "post"
1212
assert request.endpoint == "/_api/test"
1313
assert request.params == {"bool": "1"}
14-
# assert request.headers == {
15-
# "charset": "utf-8",
16-
# "content-type": "application/json",
17-
# "foo": "bar",
18-
# }
14+
assert request.headers["charset"] == "utf-8"
15+
assert request.headers["content-type"] == "application/json"
16+
assert request.headers["foo"] == "bar"
1917
assert request.data is None
2018

2119

@@ -30,11 +28,9 @@ def test_request_string_data() -> None:
3028
assert request.method == "post"
3129
assert request.endpoint == "/_api/test"
3230
assert request.params == {"bool": "1"}
33-
# assert request.headers == {
34-
# "charset": "utf-8",
35-
# "content-type": "application/json",
36-
# "foo": "bar",
37-
# }
31+
assert request.headers["charset"] == "utf-8"
32+
assert request.headers["content-type"] == "application/json"
33+
assert request.headers["foo"] == "bar"
3834
assert request.data == "test"
3935

4036

@@ -66,9 +62,7 @@ def test_request_transaction_data() -> None:
6662
assert request.method == "post"
6763
assert request.endpoint == "/_api/test"
6864
assert request.params == {"bool": "1"}
69-
# assert request.headers == {
70-
# "charset": "utf-8",
71-
# "content-type": "application/json",
72-
# "foo": "bar",
73-
# }
65+
assert request.headers["charset"] == "utf-8"
66+
assert request.headers["content-type"] == "application/json"
67+
assert request.headers["foo"] == "bar"
7468
assert request.data == {"baz": "qux"}

0 commit comments

Comments
 (0)