Implement getIndexes method #373
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apetenchea
reviewed
Jun 10, 2025
| @@ -1299,6 +1299,34 @@ def response_handler(resp: Response) -> Json: | |||
|
|
|||
| return self._execute(request, response_handler) | |||
|
|
|||
| def get_indexes(self, with_stats: bool, with_hidden: bool) -> Result[Json]: | |||
There was a problem hiding this comment.
Hey @alexbakharew,
Can you add these two parameters to the indexes() (at line 1220) method instead?
I think having two methods will get redundant, and indexes() is already a known part of the API and documented.
Please either include these parameters as Optional[bool] and set them to None by default, or just bool with a default value of False. You might have to adjust the format_index method in order to get the full result back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.