Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Baseline Metrics for Comparison #3

Closed
nsryan2 opened this issue Jun 4, 2024 · 4 comments
Closed

Calculate Baseline Metrics for Comparison #3

nsryan2 opened this issue Jun 4, 2024 · 4 comments
Assignees
Labels
Enhancement Build on an existing feature

Comments

@nsryan2
Copy link
Member

nsryan2 commented Jun 4, 2024

Add the comparison metrics to the baseline_reactor_analysis.ipynb. We need:

  1. Isotopic tracking.
  2. SWU calculations.
  3. Waste mass.
  4. Energy produced.
  5. Mass of fuel entering the reactor.
  6. Mass of fuel leaving the reactor.

This issue can be closed with a discussion of which metrics are needed, and a PR that adds the corresponding calculations to all of the *_analysis.ipynb notebooks for each scenario.

@nsryan2 nsryan2 self-assigned this Jun 4, 2024
@nsryan2 nsryan2 moved this to Todo in NRyan_ORNL_24 Jun 6, 2024
@nsryan2
Copy link
Member Author

nsryan2 commented Jun 7, 2024

Maybe something akin to from ANN LWR? https://github.com/jbae11/ann_pwr/blob/ann_lwr/scripts/analysis.ipynb Adding in an isotopics comparison.

@nsryan2
Copy link
Member Author

nsryan2 commented Jun 10, 2024

I made the two fuel cycles the exact same facilities because when I had one fuel go through fabrication, the plot looked like (I think because the fabrication facility was constantly asking for one of the fuels even though it wasn't being used by the reactor anymore):
image
Whereas (the numbers need to be refined, this is a demonstration of the expected shape) it should look something like:
image

@nsryan2
Copy link
Member Author

nsryan2 commented Jun 27, 2024

As of #31 I have implemented a slight variation on the Cymetric functions that do the isotopic tracking in the simulations, now they use the built-in version of PyNE that Cyclus has instead of relying on the user to built PyNE themselves.

@nsryan2 nsryan2 moved this from Todo to In Progress in NRyan_ORNL_24 Jun 27, 2024
@nsryan2 nsryan2 moved this from In Progress to Todo in NRyan_ORNL_24 Jun 27, 2024
@nsryan2 nsryan2 added the Enhancement Build on an existing feature label Jul 11, 2024
@nsryan2
Copy link
Member Author

nsryan2 commented Jul 29, 2024

As of #57, each of the 6 metrics outlined in the initial comment have been implemented in a standard way for each of the scenarios.

@nsryan2 nsryan2 closed this as completed Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in NRyan_ORNL_24 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Build on an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant